Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scale] fix NPE #8013

Closed
wants to merge 2 commits into from
Closed

[scale] fix NPE #8013

wants to merge 2 commits into from

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 25, 2020

Fixes #8011

Signed-off-by: Jan N. Klug [email protected]

@J-N-K
fix NPE
dbdaa30 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jun 25, 2020
@J-N-K J-N-K requested a review from clinique as a code owner June 25, 2020 20:01
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister requested changes Jun 25, 2020
View reviewed changes
bundles/org.openhab.transform.scale/conf/transform/scale/spektrum.scale Outdated
[..10]=Kaltweiß
]10..90[=Gemischt
[90..100]=Warmweiß
NaN=Unbekannt
Copy link
Contributor

@cpmeister cpmeister Jun 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline here

clinique
clinique approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K
address review comments
8bf566e 
Signed-off-by: Jan N. Klug <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the spektrum.scale file not be called spektrum_de.scale or contain english text?

DerOetzi
DerOetzi requested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@DerOetzi DerOetzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to use a more generic test case file

@J-N-K J-N-K closed this Jun 26, 2020
@J-N-K J-N-K deleted the fix-8011 branch June 26, 2020 22:08
@J-N-K
Copy link
Member Author

J-N-K commented Jun 26, 2020

Please someone else fix this one.

@clinique
Copy link
Contributor

@J-N-K : why did you close your fix ?

@J-N-K
Copy link
Member Author

J-N-K commented Jun 27, 2020

If the number of review comments approaches the number of changed lines, it‘s not worth the effort.

@DerOetzi DerOetzi mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand left review comments

@DerOetzi DerOetzi DerOetzi requested changes

@cpmeister cpmeister cpmeister requested changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in ScaleTransformationService
6 participants
@J-N-K @TravisBuddy @clinique @cpmeister @Hilbrand @DerOetzi