-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] fix group handling #8058
Conversation
Signed-off-by: Eugen Freiter <[email protected]>
Is this behavior properly documented in the README? |
Signed-off-by: Eugen Freiter <[email protected]>
it seems to be expected behaviour and it was working that way before. This PR fixes basically a bug. |
Travis tests have failedHey @yfre, |
@J-N-K i have updated the documentation. is anything else open here? i would love to merge this before 2.6.7 as it is pretty ugly bug |
Travis fails in Java11 build while using SAT. |
* fix group handling Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: MPH80 <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* fix group handling Signed-off-by: Eugen Freiter <[email protected]>
PR #7967 creates sometimes one accessory twice:
there are following cases that should be supported:
this PR fixes the 2) case. all 3 cases are tested and working correctly. added comment describing the cases
Signed-off-by: Eugen Freiter [email protected]