-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] add support for group switches #7967
Conversation
Signed-off-by: Eugen Freiter <[email protected]>
Travis tests have failedHey @yfre, |
Travis tests have failedHey @yfre, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: CSchlipp <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: MPH80 <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
as discussed here
https://community.openhab.org/t/problems-with-homekit-switchable-feature-on-switch-groups/100702
and here
https://community.openhab.org/t/homekit-could-not-find-existing-mac/100845/26
current HomeKit binding does not support groups with a base item, eg.
it would create only one accessory - for the group but not for light_1 and light_2. the logic is following: if an item is part of bigger group with homekit tag, then the item is a characteristic of this homekit accessory/group.
this PR fix this issue by ignoring groups with base item.
Signed-off-by: Eugen Freiter [email protected]