[hue] Add support for groups/rooms #7476

lolodomo · 2020-04-25T19:55:34Z

Signed-off-by: Laurent Garnier [email protected]

cpmeister · 2020-04-25T23:16:22Z

...nhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueGroupHandler.java

+
+    private @NonNullByDefault({}) String groupId;
+
+    private final Logger logger = LoggerFactory.getLogger(HueGroupHandler.class);


please move final fields above non-final fields

DerOetzi

Hi @lolodomo,

thanks for introducing Groups to hue binding. Can you please my question, whether hue groups support only channel on off switch, or although for example brightness or hsb color

DerOetzi · 2020-04-25T23:46:52Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/Group.xml

+		<label>Hue Group</label>
+		<description>A group of lights or a room that could be switched on and off.</description>
+
+		<channels>


I'm not sure, but is on/off switch really the only channel supported by groups. I think they support brightness and HSB as well?

I did not see that until today but yes the hue app allows setting the brightness of a group. And the brightness of a group seems to be the average brightness of its on lights . I will add the brightness control.
For the color control, I don't know yet if this is possible.

I added a comment on the issue: #7476
Based on the unofficial documentation you can send any parameter to a group as you would do with a single light:

http://www.burgestrand.se/hue-api/api/groups/

http://www.burgestrand.se/hue-api/api/lights/#changing-light-color-and-turning-them-onoff

Maybe give it a try?

I have now added brightness control in addition to switch control.

yes I think the group can really handle all of the light commands as well

I have now added control control.

I have now added color temperature control.

TravisBuddy · 2020-04-26T10:59:13Z

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

TravisBuddy · 2020-04-26T22:42:31Z

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

regnets · 2020-04-27T08:29:04Z

Ok just tested the binding.

After some fiddling arround, this works great! Its so much cleaner to just turn on/turn off a room instead of turning 13 lights in serial on/off, this is so much more responsible!

I will attach my configuration if someone is also curios about that binding:
Things:

Bridge hue:bridge:00178827902c "Bridge: Philips Hue" [ ipAddress="philips-hue", userName="" ] {
 group Hue_Gruppe_Kueche "Philips Hue: Gruppe Kueche" [ groupId="6" ]
}

Items:

Switch Hue_Gruppe_Kueche_Schalter "Gruppe Küche" <wallswitch>  (Alle_Items) { channel="hue:group:00178827902c:Hue_Gruppe_Kueche:switch" }
Dimmer Hue_Gruppe_Kueche_Dimmer   "Gruppe Küche" <slider>      (Alle_Items) { channel="hue:group:00178827902c:Hue_Gruppe_Kueche:brightness" }
Color  Hue_Gruppe_Kueche_Farbe    "Gruppe Küche" <colorlight>  (Alle_Items) { channel="hue:group:00178827902c:Hue_Gruppe_Kueche:color" }

Here are my findings:

Hue Entertainment Areas are recognized as groups/rooms, i think we need to hide these.
I got a Hue Group 0 which i dont know, as of testing this looks like the hue group for all lights. Maybe it would be a good idea to rename this group for discovery into "Everything" or something similar.
For the configuration we are currently using "group" as thing type. Is there a zigbee id for groups of things? So that the configuration would be more to philips current standard?
Besides the color channel, the color temperature channel would be also a great addition.

regnets · 2020-04-27T08:44:36Z

I just had a look at the zigbee light link user guide. It seems like groups are clusters of zigbee lights.

So based on the documentation i would propose to use 0004 as group thing type. Have a look at page 23 of that pdf. What do you think about that?

https://www.nxp.com/docs/en/user-guide/JN-UG-3091.pdf

lolodomo · 2020-04-27T09:12:02Z

What is a Hue Entertainment Area ? How can I identify it ? Does it contain lights ? How do you create such an area with the hue app ?

Regarding the group 0, I agree it has to be renamed, I propose "All lights".

No problem to use 0004 as thing type.

Color temperature control will be added.

lolodomo · 2020-04-27T09:19:07Z

After a Google search, I think you are talking about the usage with a Hue Play HDMI Sync Box.

regnets · 2020-04-27T09:19:35Z

A Hue Entertainment Area is used for the Hue Entertainment Sync. You can create an Entertainment Area in the Hue App in Settings "Entertainment Zones". It is used for light synchronization with the TV through the HDMI Sync Box or a Windows App.

Have a look at it:
https://www2.meethue.com/en-us/entertainment/sync-with-pc

There are also a lot of youtube videos showing this functionality.

On how to identify theses groups - i don't know.

regnets · 2020-04-27T09:20:09Z

After a Google search, I think you are talking about the usage with a Hue Play HDMI Sync Box.

Yes!

regnets · 2020-04-27T09:28:32Z

@lolodomo If you are interested, there is also a feature request for scene integration #6043. I added a bounty for that request. Maybe this can be done quite fast as you are currently working on that binding.

lolodomo · 2020-04-27T09:42:00Z

Looking at the result of the groups requests, it looks like it exists a "type" field. It can take the value ""LightGroup" or "Room". Maybe this type is different for a Hue Entertainment Areas. I have a bridge v1 and the app does not to create such area. I will log the group type so that you can tell me what value you get for Hue Entertainment Areas.

regnets · 2020-04-27T11:09:18Z

Looking at the result of the groups requests, it looks like it exists a "type" field. It can take the value ""LightGroup" or "Room". Maybe this type is different for a Hue Entertainment Areas. I have a bridge v1 and the app does not to create such area. I will log the group type so that you can tell me what value you get for Hue Entertainment Areas.

Here is my output from api/.../groups:

{
    "1": {
        "name": "Entertainment Wohnzimmer",
        "lights": [
            "47",
            "40",
            "41"
        ],
        "sensors": [],
        "type": "Entertainment",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "TV",
        "stream": {
            "proxymode": "auto",
            "proxynode": "/lights/47",
            "active": false,
            "owner": null
        },
        "locations": {
            "47": [
                -0.63,
                0.82,
                0.00
            ],
            "40": [
                0.69,
                0.83,
                0.00
            ],
            "41": [
                1.00,
                0.08,
                1.00
            ]
        },
        "action": {
            "on": false,
            "bri": 190,
            "hue": 7170,
            "sat": 225,
            "effect": "none",
            "xy": [
                0.5267,
                0.4133
            ],
            "ct": 500,
            "alert": "none",
            "colormode": "ct"
        }
    },
    "2": {
        "name": "Schlafzimmer Nachttisch",
        "lights": [
            "37",
            "62"
        ],
        "sensors": [],
        "type": "Zone",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Bedroom",
        "action": {
            "on": false,
            "bri": 254,
            "hue": 40010,
            "sat": 22,
            "effect": "none",
            "xy": [
                0.3612,
                0.3669
            ],
            "ct": 222,
            "alert": "select",
            "colormode": "ct"
        }
    },
    "3": {
        "name": "Badezimmer",
        "lights": [
            "61",
            "25"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": true
        },
        "recycle": false,
        "class": "Bathroom",
        "action": {
            "on": false,
            "bri": 254,
            "alert": "select"
        }
    },
    "4": {
        "name": "Wohnzimmer",
        "lights": [
            "30",
            "10",
            "11",
            "8",
            "9",
            "7",
            "40",
            "41",
            "47"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Living room",
        "action": {
            "on": false,
            "bri": 190,
            "hue": 7170,
            "sat": 225,
            "effect": "none",
            "xy": [
                0.5266,
                0.4133
            ],
            "ct": 500,
            "alert": "none",
            "colormode": "ct"
        }
    },
    "5": {
        "name": "Flur",
        "lights": [
            "31",
            "59"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Hallway",
        "action": {
            "on": false,
            "bri": 254,
            "ct": 370,
            "alert": "select",
            "colormode": "ct"
        }
    },
    "6": {
        "name": "Kueche",
        "lights": [
            "42",
            "28",
            "22",
            "23",
            "13",
            "39",
            "53",
            "60"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": true
        },
        "recycle": false,
        "class": "Kitchen",
        "action": {
            "on": false,
            "bri": 254,
            "hue": 41491,
            "sat": 78,
            "effect": "none",
            "xy": [
                0.3120,
                0.3280
            ],
            "ct": 153,
            "alert": "select",
            "colormode": "hs"
        }
    },
    "7": {
        "name": "Schlafzimmer",
        "lights": [
            "37",
            "57",
            "62"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Bedroom",
        "action": {
            "on": false,
            "bri": 254,
            "hue": 40010,
            "sat": 22,
            "effect": "none",
            "xy": [
                0.3612,
                0.3669
            ],
            "ct": 222,
            "alert": "select",
            "colormode": "ct"
        }
    },
    "8": {
        "name": "Custom group for $lights",
        "lights": [
            "25"
        ],
        "sensors": [],
        "type": "LightGroup",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": true,
        "action": {
            "on": false,
            "alert": "select"
        }
    },
    "9": {
        "name": "Allgemein",
        "lights": [
            "26"
        ],
        "sensors": [],
        "type": "Room",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Other",
        "action": {
            "on": false,
            "alert": "select"
        }
    },
    "10": {
        "name": "Wohnzimmer Decke",
        "lights": [
            "10",
            "11",
            "8",
            "9",
            "7"
        ],
        "sensors": [],
        "type": "Zone",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": false,
        "class": "Living room",
        "action": {
            "on": false,
            "bri": 2,
            "alert": "select"
        }
    }
}

So i can see basically three different group types: Entertainment, Zone and Room. I am not sure what my group 8 is :D.

regnets · 2020-04-27T11:10:56Z

Thinking a bit longer about Group 8:

    "8": {
        "name": "Custom group for $lights",
        "lights": [
            "25"
        ],
        "sensors": [],
        "type": "LightGroup",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": true,
        "action": {
            "on": false,
            "alert": "select"
        }
    },

I think this is a hidden Group created by the hue bridge to control a single lamp with the Hue Dimmer Switch, as Light Number 25 is the Heater in my Bathroom, so we should also need to hide the type Lightgroup.

DerOetzi · 2020-04-27T11:29:01Z

I just had a look at the zigbee light link user guide. It seems like groups are clusters of zigbee lights.

So based on the documentation i would propose to use 0004 as group thing type. Have a look at page 23 of that pdf. What do you think about that?

https://www.nxp.com/docs/en/user-guide/JN-UG-3091.pdf

Can anyone explain me why we are using always the zigbee id for thing-types. I think this is really a pain to use not speaking names for things but cryptic numbers for both developers of binding but above all for users of the binding. I would prefer it to have speaking things name like: dimmable, colorlight, presencesensor, group etc. I know this would be a breaking change for the binding, but in my opinion, would make life for all of us easier in the long run. So maybe we can leave group instead of 0004 and make a new pull request for changing other thing names?

regnets · 2020-04-27T11:35:23Z

I just had a look at the zigbee light link user guide. It seems like groups are clusters of zigbee lights.
So based on the documentation i would propose to use 0004 as group thing type. Have a look at page 23 of that pdf. What do you think about that?
https://www.nxp.com/docs/en/user-guide/JN-UG-3091.pdf

Can anyone explain me why we are using always the zigbee id for thing-types. I think this is really a pain to use not speaking names for things but cryptic numbers for both developers of binding but above all for users of the binding. I would prefer it to have speaking things name like: dimmable, colorlight, presencesensor, group etc. I know this would be a breaking change for the binding, but in my opinion, would make life for all of us easier in the long run. So maybe we can leave group instead of 0004 and make a new pull request for changing other thing names?

I totally agree with you. I just made the proposal to use 0004 in order to use the same standard. Maybe this is a thing which can be discussed with @kaikreuzer ? I would personally also prefer more memorable names.

lolodomo · 2020-04-27T11:36:14Z

Here is a new version with the following changes:

Optimized way to retrieve groups information
Hue Entertainment areas ignored by the discovery process
Group 0 labelled "All lights" by the discovery process
Group type added to the label by the discovery process
Thing type for group is now 0004

DerOetzi · 2020-04-27T11:41:16Z

Thinking a bit longer about Group 8:
    "8": {
        "name": "Custom group for $lights",
        "lights": [
            "25"
        ],
        "sensors": [],
        "type": "LightGroup",
        "state": {
            "all_on": false,
            "any_on": false
        },
        "recycle": true,
        "action": {
            "on": false,
            "alert": "select"
        }
    },
I think this is a hidden Group created by the hue bridge to control a single lamp with the Hue Dimmer Switch, as Light Number 25 is the Heater in my Bathroom, so we should also need to hide the type Lightgroup.

I don't think it's a good thing to hide Lightgroup, this is the basic group type for lights or plugs. Many diy hue bridges for example deconz use only groups of this type

lolodomo · 2020-04-27T11:46:56Z

I don"r hide the groups of type "LightGroup"; I only hide the ones of type "Entertainment".

regnets · 2020-04-27T11:50:58Z

Ok, here is how my inbox now looks like:

I would prefer the group type in the ?detailed description?, this would be also suitable for the release version. I made a mock up for this:

As you can see Group 0 is not renamed to "All lights", maybe this is an issue with my cache or temporary folders? I just removed the old jar waited a few minutes and copied the new jar in the addon folder.

I like @DerOetzi idea about renaming the thing types for that binding. I am curios if we could do something like a downwards compatible version. To accept both the Zigbee Id and from now on the new thing types.

lolodomo · 2020-04-27T11:52:02Z

@lolodomo If you are interested, there is also a feature request for scene integration #6043. I added a bounty for that request. Maybe this can be done quite fast as you are currently working on that binding.

There was PR 6044 for that, no ?
But the Git link to this PR is broken ! Maybe the user deleted his PR.

regnets · 2020-04-27T11:53:57Z

@lolodomo If you are interested, there is also a feature request for scene integration #6043. I added a bounty for that request. Maybe this can be done quite fast as you are currently working on that binding.

There was PR 6044 for that, no ?
But the Git link to this PR is broken ! Maybe the user deleted his PR.

Yes, thats why I asked you :). Maybe this could also be added to rooms as scenes are always related to groups (rooms/zones).

lolodomo · 2020-04-27T11:56:45Z

@lolodomo If you are interested, there is also a feature request for scene integration #6043. I added a bounty for that request. Maybe this can be done quite fast as you are currently working on that binding.

There was PR 6044 for that, no ?
But the Git link to this PR is broken ! Maybe the user deleted his PR.

Yes, thats why I asked you :). Maybe this could also be added to rooms as scenes are always related to groups (rooms/zones).

I will first wait for the merge of this PR.

lolodomo · 2020-04-27T12:00:54Z

As you can see Group 0 is not renamed to "All lights", maybe this is an issue with my cache or temporary folders? I just removed the old jar waited a few minutes and copied the new jar in the addon folder.

Group 0 is added manually because with old bridges, it was not returned by the "groups" request. Probably with your more recent bridge or firmware, this "bug" was fixed by Philips. So I have a little change to do to not request this group if already provided by the "groups" request and for the renaming in the discovery, I have to consider its id and not its name.

DerOetzi · 2020-04-27T12:09:27Z

Here is a new version with the following changes:

* Optimized way to retrieve groups information

* Hue Entertainment areas ignored by the discovery process

* Group 0 labelled "All lights" by the discovery process

* Group type added to the label by the discovery process

* Thing type for group is now 0004

org.openhab.binding.hue-2.5.5-SNAPSHOT.zip

Not only about the speaking name argument above, but I think with using 0004 ClusterID for groups, we start to mix up two different layers of ZigBee device layer and cluster layer.

lolodomo · 2020-04-27T12:11:21Z

New version for renaming group 0.

Not only about the speaking name argument above, but I think with using 0004 ClusterID for groups, we start to mix up two different layers of ZigBee device layer and cluster layer.

This was your idea ! I can revert.

lolodomo · 2020-04-27T12:12:41Z

I would prefer the group type in the ?detailed description?, this would be also suitable for the release version. I made a mock up for this

This is not possible. Paper UI displays the thing type label at this place.

regnets · 2020-04-27T12:14:02Z

New version for renaming group 0:
org.openhab.binding.hue-2.5.5-SNAPSHOT.zip

Not only about the speaking name argument above, but I think with using 0004 ClusterID for groups, we start to mix up two different layers of ZigBee device layer and cluster layer.

This was your idea ! I can revert.

You are absolutely right, that is my idea.

I just wanted to stay to the current notation. However, I don't like the notation myself.

If we can decide that i would prefer for all thing more memorable, self descriptive names.

lolodomo · 2020-04-27T13:00:18Z

So let me know if the last version is OK.
I still have to add the color temperature control.

DerOetzi · 2020-04-27T13:27:36Z

Renaming thing types will not be part of this PR. I don't like this idea because it will break the setup of all users using this binding !

Totally agree: That shouldn't be part of this PR because it should be discussed thoroughly for being a breaking change. Although I basically support the idea of descriptive thing names

regnets · 2020-04-27T13:47:58Z

So let me know if the last version is OK.
I still have to add the color temperature control.

I had to clean my cache and my tmp directory, after that everything looks fine and works as expected. Also the Group 0 is now named All Lights.

TravisBuddy · 2020-04-27T15:55:28Z

Travis tests have failed

Hey @lolodomo,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 512bf4f0-8883-11ea-88d0-3540a036c4cf

lolodomo · 2020-04-27T19:56:22Z

Color temperature control is now implemented.
I rebased the PR to solve the conflict.
The enhancement is finished in my point of view.
Here is new jar for testing:
org.openhab.binding.hue-2.5.5-SNAPSHOT.zip

TravisBuddy · 2020-05-01T14:13:43Z

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

TravisBuddy · 2020-05-01T19:37:01Z

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

lolodomo · 2020-05-01T19:37:43Z

I have a doubt if this is necessary to have 4 channels on a group thing: switch, brigthness, color and color_temperature.

lolodomo · 2020-05-01T22:28:14Z

@cpmeister : could you please have a final look ?
@regnets confirmed that it works well.

cpmeister · 2020-05-01T23:19:17Z

...hab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueBridgeHandler.java

+                                "Could not notify groupStatusListeners for unknown event type " + type);
+                }
+            } catch (Exception e) {
+                logger.error("An exception occurred while calling the Group Listeners", e);


The error logging level should be reserved for issues catastrophic enough to threaten the operation of openHab itself. An error in a binding shouldn't qualify for this. Please read the openHab coding guidelines for expected use of logging in bindings.

My general rule for logging levels is:

trace - used for normal expected execution paths

debug - used for unexepected execution paths, but well within normal operation

info - used for notable points in an execution path, like a milestone. (in openhab we try reserve this logging level for the core, so bindings should rarely ever call this.)

warn - used for notable unexpected execution paths that a regular user (not just a developer) should be notified of. Warnings should be used to indicate that something not-normal occurred and user intervention is required to resolve. Warnings do not indicate a failure to operate merely an abnormal condition of operation that can still be handled by the binding. Failures in binding operation should be indicated by changing the thing status to offline.

error - used to indicate catastrophic program failure. This should be used to indicate a catastrophic failure in openhab's ability to operate. A failure in a binding would never cause openhab as a whole to fail so a failure in a bindings should never log an error. Instead that failure should be indicated by changing the thing status.

Ok, updated.

...nhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueGroupHandler.java

cpmeister · 2020-05-01T23:27:30Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/Group.xml

+				<description>The group identifier identifies one certain hue group or room.</description>
+				<required>true</required>
+			</parameter>
+			<parameter name="fadetime" type="integer" min="0" step="100">


Suggested change

<parameter name="fadetime" type="integer" min="0" step="100">

<parameter name="fadetime" type="integer" min="0" step="100" unit="ms">

Ok, done.
Another PR would be welcome to fix all other thing types.

cpmeister · 2020-05-01T23:27:40Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/Group.xml

+			</parameter>
+			<parameter name="fadetime" type="integer" min="0" step="100">
+				<label>Fade Time</label>
+				<description>Fade time in ms for changing values</description>


Suggested change

<description>Fade time in ms for changing values</description>

<description>Fade time for changing values</description>

I revert this one becauuse Paper UI is not displaying th eunit, so without this information in the description, the user will not know what is the unit of this configuration setting.

For your information: eclipse-archived/smarthome#3974

I know that some UIs (e.g. Paper UI) - which will be removed in OH3 - do not show this "unit" but we prefer to not have it inside the description.

Without the unit in the description, the user will not know how to adjust the setting.
Hopefully, the unit is inside the description in every existing bindings.
I would suggest to change that when OH3 is released, not before. And this will require to change more or less every bindings.

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

lolodomo · 2020-05-02T16:11:39Z

Ok, I have now rebased the PR to solve the conflict.

TravisBuddy · 2020-05-02T16:12:52Z

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

cpmeister

LGTM

cpmeister · 2020-05-02T18:59:32Z

Manually checked sign-off

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

lolodomo requested a review from cweitkamp as a code owner April 25, 2020 19:55

DerOetzi mentioned this pull request Apr 25, 2020

[hue] Added humidity and pressure sensor #7426

Closed

cpmeister requested changes Apr 25, 2020

View reviewed changes

DerOetzi reviewed Apr 26, 2020

View reviewed changes

lolodomo force-pushed the hue_rooms branch from 646e843 to c924ec6 Compare April 27, 2020 19:54

cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 28, 2020

cpmeister requested changes May 1, 2020

View reviewed changes

[hue] Add support for groups/rooms

a0027e2

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

lolodomo force-pushed the hue_rooms branch from c86f3e6 to a0027e2 Compare May 2, 2020 16:09

cpmeister approved these changes May 2, 2020

View reviewed changes

cpmeister merged commit 3a0e614 into openhab:2.5.x May 2, 2020

cpmeister added this to the 2.5.5 milestone May 2, 2020

lolodomo deleted the hue_rooms branch May 2, 2020 19:09

LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020

[hue] Add support for groups/rooms (openhab#7476)

4a4b403

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020

[hue] Add support for groups/rooms (openhab#7476)

2b3af1c

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020

[hue] Add support for groups/rooms (openhab#7476)

c4ef99e

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[hue] Add support for groups/rooms (openhab#7476)

a4b4c33

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[hue] Add support for groups/rooms (openhab#7476)

eb68a50

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[hue] Add support for groups/rooms (openhab#7476)

d060e0c

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[hue] Add support for groups/rooms (openhab#7476)

03a5e1e

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>

DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020

[hue] Add support for groups/rooms (openhab#7476)

d55b574

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020

[hue] Add support for groups/rooms (openhab#7476)

8849fc4

Fix openhab#7419 Signed-off-by: Laurent Garnier <[email protected]>


		private @NonNullByDefault({}) String groupId;

		private final Logger logger = LoggerFactory.getLogger(HueGroupHandler.class);

	<parameter name="fadetime" type="integer" min="0" step="100">
	<parameter name="fadetime" type="integer" min="0" step="100" unit="ms">

	<description>Fade time in ms for changing values</description>
	<description>Fade time for changing values</description>

[hue] Add support for groups/rooms #7476

[hue] Add support for groups/rooms #7476

Conversation

lolodomo commented Apr 25, 2020

Choose a reason for hiding this comment

DerOetzi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Apr 26, 2020

Travis tests have failed

TravisBuddy commented Apr 26, 2020

Travis tests have failed

regnets commented Apr 27, 2020

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020

lolodomo commented Apr 27, 2020

regnets commented Apr 27, 2020

regnets commented Apr 27, 2020

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020

regnets commented Apr 27, 2020

regnets commented Apr 27, 2020

DerOetzi commented Apr 27, 2020 • edited Loading

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020 • edited Loading

DerOetzi commented Apr 27, 2020

lolodomo commented Apr 27, 2020

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020

lolodomo commented Apr 27, 2020

DerOetzi commented Apr 27, 2020

lolodomo commented Apr 27, 2020 • edited Loading

lolodomo commented Apr 27, 2020

regnets commented Apr 27, 2020

lolodomo commented Apr 27, 2020

DerOetzi commented Apr 27, 2020

regnets commented Apr 27, 2020

TravisBuddy commented Apr 27, 2020

Travis tests have failed

TravisBuddy Request Identifier: 512bf4f0-8883-11ea-88d0-3540a036c4cf

lolodomo commented Apr 27, 2020

TravisBuddy commented May 1, 2020

Travis tests have failed

TravisBuddy commented May 1, 2020

Travis tests have failed

lolodomo commented May 1, 2020

lolodomo commented May 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolodomo May 2, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolodomo May 2, 2020 • edited Loading

Choose a reason for hiding this comment

lolodomo commented May 2, 2020

TravisBuddy commented May 2, 2020

Travis tests have failed

cpmeister left a comment

Choose a reason for hiding this comment

cpmeister commented May 2, 2020 • edited Loading

DerOetzi commented Apr 27, 2020 •

edited

Loading

lolodomo commented Apr 27, 2020 •

edited

Loading

lolodomo commented Apr 27, 2020 •

edited

Loading

lolodomo May 2, 2020 •

edited

Loading

lolodomo May 2, 2020 •

edited

Loading

cpmeister commented May 2, 2020 •

edited

Loading