[hue] Added humidity and pressure sensor #7426

DerOetzi · 2020-04-19T20:35:26Z

First draft to add humidity and pressure sensor to hue binding

see #7420

I'm not sure about Device IDs of this two devices

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

cweitkamp

Thanks for the improvement. Some remarks inside.

cweitkamp · 2020-04-20T06:03:34Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/channels.xml

+	<!-- Pressure Channel -->
+	<channel-type id="pressure">
+		<item-type>Number:Pressure</item-type>
+		<label>Relative Humidity</label>


Suggested change

<label>Relative Humidity</label>

<label>Relative Pressure</label>

cweitkamp · 2020-04-20T06:04:01Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/channels.xml

+	<channel-type id="pressure">
+		<item-type>Number:Pressure</item-type>
+		<label>Relative Humidity</label>
+		<description>Current relative humidity.</description>


Suggested change

<description>Current relative humidity.</description>

<description>Current relative pressure.</description>

cweitkamp · 2020-04-20T06:05:54Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/channels.xml

+
+	<!-- Humidity Channel -->
+	<channel-type id="humidity">
+		<item-type>Number</item-type>


You can use Number:Dimensionless for this channel type and update its state by SmartHomeUnits.PERCENT (see SmartHomeUnits.PERCENT).

cweitkamp · 2020-04-20T06:07:29Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/HumiditySensor.xml

+
+		<representation-property>uniqueId</representation-property>
+
+		<config-description>


I think it is time to introduced a "config-description-uri" for these new thing types to avoid too much duplicate code.

I have introduced the config-description, for all things except PresenceSensor (0107) and LightLevelSensor (0106) because they have special parameters. Please have a look.

cweitkamp · 2020-04-20T06:08:32Z

bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/i18n/hue_de.properties

@@ -1,34 +1,38 @@
 # binding


What happened to this file? Did you eventually change the encoding? We require ISO-8859.

Ups I have seen this already yesterday and forgot to push

cweitkamp · 2020-04-20T06:11:31Z

bundles/org.openhab.binding.hue/README.md

+| dark              | Switch             | This channel indicates whether the light level is below the darkness threshold or not.                                                  | 0106                                     |
+| daylight          | Switch             | This channel indicates whether the light level is below the daylight threshold or not.                                                  | 0106                                     |
+| presence          | Switch             | This channel indicates whether a motion is detected by the sensor or not.                                                               | 0107                                     |
+| temperature       | Number:Temperature | This channel shows the current temperature measured by the sensor.                                                                      | 0302                                     |


Can you add the new channel here?

added Channels

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

TravisBuddy · 2020-04-20T08:44:16Z

Travis tests have failed

Hey @DerOetzi,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

DerOetzi · 2020-04-20T11:12:59Z

@cweitkamp I would offer you to do some code clean ups to reduce checkstyle warnings. To be able to concentrate on the real errors. But I would do this in a seperate branch after this pull request is finished

J-N-K · 2020-04-20T11:14:15Z

One question: is it possible to pair these sensors With a hue bridge? Or are they paired to a deconz and only made available via the hue binding instead of the deconz?

DerOetzi · 2020-04-20T11:27:28Z

One question: is it possible to pair these sensors With a hue bridge? Or are they paired to a deconz and only made available via the hue binding instead of the deconz?

They are connected to deconz at the moment, for not having a hue bridge at the moment, but I have read somewhere the xiaomi aqara sensors can be paired with hue bridge as well, but can't find the link now. :(

J-N-K · 2020-04-20T11:37:56Z

But then: why don‘t we use them on the deconz bridge? And if they are used on the hue bridge, are they doubled on the deconz?

DerOetzi · 2020-04-20T11:57:20Z

But then: why don‘t we use them on the deconz bridge? And if they are used on the hue bridge, are they doubled on the deconz?

Yes they are already present at the deconz binding. Didn't thought about this, because I'm using my PresenceSensors although for some time with hue binding without having to configure an extra binding (which I was glad to get rid of for being instable). So I didn't think about the deconz binding anymore, when writing the feature request. I would understand the argument to have only supported things inside hue binding and could withdraw this PR if you wish.

J-N-K · 2020-04-21T17:18:17Z

Don't get me wrong, I'm not against this change, I only fear that the same physical entity on two bridges might be confusing. If pairing the sensors with the hue bridge actually works, we could drop them from the deconz.

cweitkamp · 2020-04-22T08:43:31Z

I agree with @J-N-K. As long as the sensors themselves do not work with Hue Bridge I do not see any reason to add support in the Hue binding. Compared to deCONZ binding the Hue binding has a big disadvantage for sensor handling because it uses a polling based strategy whereas deCONZ binding uses a websocket and event based handling.

Thanks for your work and of course

I would offer you to do some code clean ups to reduce checkstyle warnings

will be very much appreciated.

DerOetzi · 2020-04-22T15:32:29Z

I cannot find the page, where I have read about the possibility to connect aqara sensors to hue bridge. So I think I will redraw this PR.

As I offered before I will do a new PR in some days with some code improvments, should I take over the changes to light-config.xml and sensor-config.xml as well?

regnets · 2020-04-22T15:36:31Z

The official Philips motion sensor has a temperature sensor built in. So it would make sense to implement this for the hue binding.

cweitkamp · 2020-04-22T15:53:59Z

@DerOetzi

should I take over the changes to light-config.xml and sensor-config.xml as well?

Pick whatever you like. I am a fan of configuration descriptions.

@regnets The temperature sensor is already available in Hue binding.

I am aware of other sensors which could be paired with Hue bridge. For example innr SP120 smart plug with integrated power and consumption measurements. But to be honest I never put them together and explored what is happening. I am using deCONZ for sensors 😉.

DerOetzi · 2020-04-25T23:13:32Z

@DerOetzi

should I take over the changes to light-config.xml and sensor-config.xml as well?

Pick whatever you like. I am a fan of configuration descriptions.

@cweitkamp
I will wait for the huge PR #7476 to be finished, because I don't want to produce lot of merge conflicts and afterwards I will have a look on the cleanup task.

DerOetzi · 2020-05-02T23:05:38Z

Closing because this sensor types are not connectable to hue system at the moment.

[hue] Added humidity and pressure sensor

a5a18f4

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

DerOetzi requested a review from cweitkamp as a code owner April 19, 2020 20:35

[hue] Fixed line-ending .classpath

a288986

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

cweitkamp reviewed Apr 20, 2020

View reviewed changes

[hue] Repaired encoding translation file

62eea83

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

Johannes DerOetzi Ott added 2 commits April 20, 2020 10:59

[hue] Fixed some review findings

7345a49

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

[hue] Refactored config-description-ref

ec5a142

Signed-off-by: Johannes DerOetzi Ott <[email protected]>

cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 22, 2020

DerOetzi mentioned this pull request Apr 22, 2020

[hue] Support for Pressure and Humidity devices #7420

Closed

cpmeister added the awaiting other PR Depends on another PR label Apr 25, 2020

DerOetzi closed this May 2, 2020

wborn removed the awaiting other PR Depends on another PR label Dec 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hue] Added humidity and pressure sensor #7426

[hue] Added humidity and pressure sensor #7426

DerOetzi commented Apr 19, 2020

cweitkamp left a comment

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

cweitkamp Apr 20, 2020

DerOetzi Apr 20, 2020

TravisBuddy commented Apr 20, 2020

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 20, 2020

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 20, 2020

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 21, 2020

cweitkamp commented Apr 22, 2020

DerOetzi commented Apr 22, 2020

regnets commented Apr 22, 2020 •

edited

Loading

cweitkamp commented Apr 22, 2020

DerOetzi commented Apr 25, 2020 •

edited

Loading

DerOetzi commented May 2, 2020

	<label>Relative Humidity</label>
	<label>Relative Pressure</label>

	<description>Current relative humidity.</description>
	<description>Current relative pressure.</description>


		<representation-property>uniqueId</representation-property>

		<config-description>

[hue] Added humidity and pressure sensor #7426

[hue] Added humidity and pressure sensor #7426

Conversation

DerOetzi commented Apr 19, 2020

cweitkamp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Apr 20, 2020

Travis tests have failed

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 20, 2020

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 20, 2020

DerOetzi commented Apr 20, 2020

J-N-K commented Apr 21, 2020

cweitkamp commented Apr 22, 2020

DerOetzi commented Apr 22, 2020

regnets commented Apr 22, 2020 • edited Loading

cweitkamp commented Apr 22, 2020

DerOetzi commented Apr 25, 2020 • edited Loading

DerOetzi commented May 2, 2020

regnets commented Apr 22, 2020 •

edited

Loading

DerOetzi commented Apr 25, 2020 •

edited

Loading