-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr064] Update configuration documentation #14291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsiepel <[email protected]>
jlaur
requested changes
Feb 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seems like some I18N cleanup is needed.
bundles/org.openhab.binding.tr064/src/main/resources/OH-INF/i18n/tr064.properties
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Feb 5, 2023
bundles/org.openhab.binding.tr064/src/main/resources/OH-INF/i18n/tr064.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
…siepel/openhab-addons into tr064-comma-seperated-list-doc
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
jlaur
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SMHRambo
pushed a commit
to SMHRambo/openhab-addons
that referenced
this pull request
Feb 14, 2023
* i18n + mac per line fix Signed-off-by: lsiepel <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* i18n + mac per line fix Signed-off-by: lsiepel <[email protected]>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* i18n + mac per line fix Signed-off-by: lsiepel <[email protected]>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* i18n + mac per line fix Signed-off-by: lsiepel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsiepel [email protected]
Replaces: #13988
Fixes: #13798