Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass invalid auth method "None" to net-smtp #12384

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Don't pass invalid auth method "None" to net-smtp #12384

merged 5 commits into from
Apr 18, 2024

Commits on Apr 16, 2024

  1. Don't pass invalid auth method "None" to net-smtp 

    It's our magic word to not pass username and password on.
    @mkllnk
    mkllnk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d6f2a53 View commit details
    Browse the repository at this point in the history

  2. Simplify SMTP auth method selection 

    Instead of using the auth method name, let's just not supply username
and password when we don't want to authenticate. The two affected
servers AU and CA don't have credentials set anyway. This is compatible.

The specs needed changing though.
    @mkllnk
    mkllnk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a41019f View commit details
    Browse the repository at this point in the history

  3. Further simplify mail options logic 

    We were always adding this option anyway, so why not declare it to start
with?
    @mkllnk
    mkllnk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7e2fced View commit details
    Browse the repository at this point in the history

  4. Remove indirection from MailSettings 

    We can simply merge the option hashes now because they are not
conditional anymore. Well, the magic `presence` method does the
conditional logic for us now.
    @mkllnk
    mkllnk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1fc4270 View commit details
    Browse the repository at this point in the history

  5. Clean up MailSettings spec 

    Best viewed with whitespace ignored.
    @mkllnk
    mkllnk committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5cd53e0 View commit details
    Browse the repository at this point in the history