Don't pass invalid auth method "None" to net-smtp

[mkllnk]

What? Why?

• Closes ArgumentError in ActionMailer::MailDeliveryJob@default #12383

The indirect dependency net-smtp introduced a new check on authentication methods. Suddenly it raised an error on our non-standard auth method "None" which indicates not to authenticate.

What should we test?

• Send an email on au-staging.
• Send an email on another staging server.
• You should receive both emails and not see anything in Bugsnag.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[rioug]

Nice one, It's always nice to see the code simplified.

[dacook]

Great, thanks for fixing this.
It's nice how improving code creates opportunity to simplify it further, thanks for going ahead and cleaning up so much! 😀

[dacook]

I'll go ahead and test this so it can be included in the release.

[dacook]

Had to fix separate unrelated issues on each staging server.

au_staging

https://staging.openfoodnetwork.org.au/admin/mail_methods/edit > Send test email
✅ Successfully received. No Bugsnag errors. Email source:

...
X-Received: by 2002:a05:6602:2549:b0:7d3:55a4:ab3f with SMTP id cg9-20020a056602254900b007d355a4ab3fmr1593149iob.15.1713404423691;
        Wed, 17 Apr 2024 18:40:23 -0700 (PDT)
Return-Path: <[email protected]>
Received: from smtp.gmail.com ([65.99.217.140])
        by smtp-relay.gmail.com with ESMTPS id x14-20020a026f0e000000b00481b24766c6sm49743jab.30.2024.04.17.18.40.21
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 17 Apr 2024 18:40:23 -0700 (PDT)
...

uk_staging

Broken, try another

fr_staging

Seems a bit unhealthy

1. client_loop: send disconnect: Broken pipe after 6m 36s.
2. "bundle exec rake assets:precompile RAILS_ENV=staging"], ... "msg": "non-zero return code" after 5m 28s.
3. client_loop: send disconnect: Broken pipe after 6m 18s.

[dacook]

fr_staging

4. Finally, success after 5m 29s

✅ Successfully received. No Bugsnag errors. Email source:

Received: by recvd-5d958566ff-2tqqg with SMTP id recvd-5d958566ff-2tqqg-1-6620C1F1-10 2024-04-18 06:47:13.857602197 +0000 UTC m=+463654.459376259
Received: from coopcircuits.fr (unknown) by geopod-ismtpd-0 (SG) with ESMTP id BmckWptOQxadziil2z65BA for <[email protected]>; Thu, 18 Apr 2024 06:47:13.742 +0000 (UTC)