-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add multiple labels in backend #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool just small changes and it seems ok to me.
I would like you to add an test for parser.
At some point we should also setup tests, at least for TaxonomyGraph !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but two small suggestions, and a possible refactor but that we can do an a separate PR (as you want).
Note @aadarsh-ram merging this PR will brake the interface (as it still use the old API…). Is it ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok perfect :-)
* Add endpoint for root nodes * Minor fixes
* Add import * Add export to github and download
@alexgarel There seems to be some issue with the docker build in this workflow: https://github.com/openfoodfacts/taxonomy-editor/actions/runs/3399253092/jobs/5652877236#step:3:330 This issue occurs after resolving conflicts in the backend Dockerfile. So, please do take a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What
Related issue(s)