Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add routes for import/export taxonomy #116

Merged
merged 19 commits into from
Nov 5, 2022
Merged

Conversation

aadarsh-ram
Copy link
Collaborator

@aadarsh-ram aadarsh-ram commented Oct 17, 2022

What

  • Add routes for importing and dumping a taxonomy

Related issue(s)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a great work.

I propose some improvements, but I approve it so you can merge as soon as you want.

backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
parser/tests/unit/test_parser_unit.py Outdated Show resolved Hide resolved
@alexgarel
Copy link
Member

@aadarsh-ram make lint can help you in the parser folder :-)

@aadarsh-ram aadarsh-ram marked this pull request as ready for review October 20, 2022 18:41
@aadarsh-ram aadarsh-ram requested a review from a team as a code owner October 20, 2022 18:41
@aadarsh-ram aadarsh-ram changed the title feat: Add route for importing taxonomy feat: Add routes for import/export taxonomy Oct 20, 2022
@aadarsh-ram
Copy link
Collaborator Author

@alexgarel I've added export functionality (Download and Github) endpoints in the last 2 commits. Please review the same.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @aadarsh-ram

I made some comment, but you are free to ignore them if you want :-) as it's more perfectionist comments.

backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/github_functions.py Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
@alexgarel
Copy link
Member

For me it's all good @aadarsh-ram

uri = os.environ.get("NEO4J_URI", "bolt://localhost:7687")
access_token = os.environ.get("GITHUB_PAT", "<Add personal access token here>")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel Please do let me know how this will be added in production/staging.

@aadarsh-ram
Copy link
Collaborator Author

@alexgarel I'll be merging this to the "multilabelnew" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add an API to list projects Add an API to add a new project Implement taxonomy import from github
2 participants