Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow slashes in the flag name regex #316

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

wildefires
Copy link

Upstream issue: #315

Description

Allows you to add a as a valid character in a flag name to allow for sensible namespacing

Motivation and Context

Allows people to namespace in a unix type fashion that makes it clear where the namespace ends and the flag begins

How Has This Been Tested?

Tested locally against existing postgres database; was able to update a flag and then get the flag back successfully

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files          26       26           
  Lines        1535     1535           
=======================================
  Hits         1257     1257           
  Misses        209      209           
  Partials       69       69
Impacted Files Coverage Δ
pkg/util/util.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4238989...c131ad0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants