Merge pull request #316 from Cull-Methi/allow-slashes

Allow slashes in the flag name regex
openflagr · Jan 29, 2020 · bdbd3a5 · bdbd3a5
2 parents 4238989 + c131ad0
commit bdbd3a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/util/util.go b/pkg/util/util.go
@@ -12,7 +12,7 @@ import (
 
 var (
 	keyLengthLimit = 63
-	keyRegex       = regexp.MustCompile(`^[\w\d-]+$`)
+	keyRegex       = regexp.MustCompile(`^[\w\d-/]+$`)
 
 	randomKeyCharset = []byte("123456789abcdefghijkmnopqrstuvwxyz")
 	randomKeyPrefix  = "k"

diff --git a/pkg/util/util_test.go b/pkg/util/util_test.go
@@ -96,6 +96,10 @@ func TestIsSafeKey(t *testing.T) {
 	b, msg = IsSafeKey(strings.Repeat("a", 64))
 	assert.False(t, b)
 	assert.NotEmpty(t, msg)
+
+	b, msg = IsSafeKey("slashes/are/valid")
+	assert.True(t, b)
+	assert.Empty(t, msg)
 }
 
 func TestPtrs(t *testing.T) {