Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-1569: Task-Runner: Add support in task-runner "process" task arrays (imploded to string with comma delimiter). #93

Merged
merged 5 commits into from
Feb 8, 2019

Conversation

sergepavle
Copy link
Member

@sergepavle sergepavle commented Jan 30, 2019

OPENEUROPA-1569

Description

For example in phpunit.xml.dist we have this code:

<?xml version="1.0" encoding="UTF-8"?>
<phpunit bootstrap="${drupal.root}/core/tests/bootstrap.php" backupGlobals="true" colors="true" >
  <php>
    <ini name="error_reporting" value="32767"/>
    <ini name="memory_limit" value="-1"/>
    <env name="SIMPLETEST_IGNORE_DIRECTORIES" value="build,vendor,node_modules,${drupal.root}"/>
    <env name="SIMPLETEST_BASE_URL" value="${drupal.base_url}"/>
    <env name="SIMPLETEST_DB" value="mysql://${drupal.database.user}:${drupal.database.password}@${drupal.database.host}:${drupal.database.port}/${drupal.database.name}"/>
  </php>
  <testsuites>
    <testsuite>
      <directory>./modules/**/tests/</directory>
      <directory>./tests/</directory>
    </testsuite>
  </testsuites>
</phpunit>

It would be nice if we could use in SIMPLETEST_IGNORE_DIRECTORIES the value ${drupal.settings.settings.file_scan_ignore_directories}.

Update of phpunit.xml.dist file in all existing components is optional in terms of ticket's scope.

Change log

  • Added:
  • Changed:
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

@drupol
Copy link
Contributor

drupol commented Jan 30, 2019

You will need to wait for OPENEUROPA-1535 (#92) to be merged, then rebase, then move forward.

dxvargas
dxvargas previously approved these changes Jan 31, 2019
drupol
drupol previously approved these changes Jan 31, 2019
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea :-)

src/Commands/AbstractDrupalCommands.php Outdated Show resolved Hide resolved
@drupol drupol dismissed stale reviews from dxvargas and themself via 56badb9 February 8, 2019 14:21
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drupol drupol merged commit c4b5725 into master Feb 8, 2019
@drupol drupol deleted the OPENEUROPA-1569 branch February 8, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants