OPENEUROPA-1535: Fix various coding style inconsistencies. #92

drupol · 2019-01-15T12:57:29Z

No description provided.

pfrenssen · 2019-01-18T15:46:45Z

I agree with these proposed changes, but ideally these should be detected automatically. In order to facilitate this I proposed a PR for the code review tool which will detect the changes which are proposed here: indentation of arrays and object chaining, and spaces around the concatenation operator: openeuropa/code-review#51

When I try out this PR in the task runner it appears that there are a number of coding standards violations that remain:

$ composer require --dev openeuropa/code-review:dev-OPENEUROPA-1535
$ ./vendor/bin/grumphp run


Deprecated: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in /home/pieter/v/task-runner/vendor/phpro/grumphp/src/Locator/ConfigurationFile.php on line 75
FILE: /home/pieter/v/task-runner/src/Commands/AbstractCommands.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  37 | ERROR | [x] Expected at least 1 space before "."; 0 found
  37 | ERROR | [x] Expected at least 1 space after "."; 0 found
 118 | ERROR | [x] Expected at least 1 space before "."; 0 found
 118 | ERROR | [x] Expected at least 1 space after "."; 0 found
 118 | ERROR | [x] Expected at least 1 space before "."; 0 found
 118 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ome/pieter/v/task-runner/src/Commands/AbstractDrupalCommands.php
----------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
  33 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
  34 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
  42 | ERROR | [x] Expected at least 1 space before "."; 0 found
  42 | ERROR | [x] Expected at least 1 space after "."; 0 found
  97 | ERROR | [x] Expected at least 1 space before "."; 0 found
  97 | ERROR | [x] Expected at least 1 space after "."; 0 found
 173 | ERROR | [x] Expected at least 1 space before "."; 0 found
 173 | ERROR | [x] Expected at least 1 space after "."; 0 found
 295 | ERROR | [x] Expected at least 1 space before "."; 0 found
 295 | ERROR | [x] Expected at least 1 space after "."; 0 found
 296 | ERROR | [x] Expected at least 1 space before "."; 0 found
 296 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/src/Commands/ChangelogCommands.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 23 | ERROR | [x] Expected at least 1 space before "."; 0 found
 23 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/src/Services/Composer.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 80 | ERROR | [x] Expected at least 1 space before "."; 0 found
 80 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/src/TaskRunner.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 144 | ERROR | [x] Expected at least 1 space before "."; 0 found
 144 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../v/task-runner/src/Tasks/CollectionFactory/CollectionFactory.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 153 | ERROR | [x] Expected at least 1 space before "."; 0 found
 153 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/tests/AbstractTest.php
----------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 33 | ERROR | [x] Expected at least 1 space before "."; 0 found
 33 | ERROR | [x] Expected at least 1 space after "."; 0 found
 61 | ERROR | [x] Expected at least 1 space before "."; 0 found
 61 | ERROR | [x] Expected at least 1 space after "."; 0 found
 71 | ERROR | [x] Expected at least 1 space before "."; 0 found
 71 | ERROR | [x] Expected at least 1 space after "."; 0 found
 71 | ERROR | [x] Expected at least 1 space before "."; 0 found
 71 | ERROR | [x] Expected at least 1 space after "."; 0 found
 81 | ERROR | [x] Expected at least 1 space before "."; 0 found
 81 | ERROR | [x] Expected at least 1 space after "."; 0 found
 95 | ERROR | [x] Expected at least 1 space before "/"; 0 found
 95 | ERROR | [x] Expected at least 1 space after "/"; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...home/pieter/v/task-runner/tests/Commands/ReleaseCommandsTest.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
  39 | ERROR | [x] Expected at least 1 space before "."; 0 found
  39 | ERROR | [x] Expected at least 1 space after "."; 0 found
  70 | ERROR | [x] Expected at least 1 space before "."; 0 found
  70 | ERROR | [x] Expected at least 1 space after "."; 0 found
 124 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 125 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 131 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 134 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 135 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 140 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
----------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/tests/CommandsTest.php
----------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 14 LINES
----------------------------------------------------------------------
  59 | ERROR | [x] Expected at least 1 space before "."; 0 found
  59 | ERROR | [x] Expected at least 1 space after "."; 0 found
  92 | ERROR | [x] Expected at least 1 space before "."; 0 found
  92 | ERROR | [x] Expected at least 1 space after "."; 0 found
 129 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 130 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 131 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 132 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 153 | ERROR | [x] Expected at least 1 space before "."; 0 found
 153 | ERROR | [x] Expected at least 1 space after "."; 0 found
 198 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 199 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 249 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 250 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 304 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 305 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 331 | ERROR | [x] Expected at least 1 space before "."; 0 found
 331 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /home/pieter/v/task-runner/tests/Tasks/CollectionFactoryTest.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 56 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 57 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 58 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 59 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 60 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 213ms; Memory: 8MB

You can fix some errors by running following command:
'/home/pieter/v/task-runner/vendor/bin/phpcbf' '--standard=./vendor/openeuropa/code-review/resources/library-phpcs-ruleset.xml' '--report=full' '--warning-severity=0' '--ignore=vendor/,loadTasks.php' '/home/pieter/v/task-runner/src/Commands/AbstractCommands.php' '/home/pieter/v/task-runner/src/Commands/AbstractDrupalCommands.php' '/home/pieter/v/task-runner/src/Commands/ChangelogCommands.php' '/home/pieter/v/task-runner/src/Services/Composer.php' '/home/pieter/v/task-runner/src/TaskRunner.php' '/home/pieter/v/task-runner/src/Tasks/CollectionFactory/CollectionFactory.php' '/home/pieter/v/task-runner/tests/AbstractTest.php' '/home/pieter/v/task-runner/tests/Commands/ReleaseCommandsTest.php' '/home/pieter/v/task-runner/tests/CommandsTest.php' '/home/pieter/v/task-runner/tests/Tasks/CollectionFactoryTest.php'
To skip commit checks, add -n or --no-verify flag to commit command

Please make sure to not commit the dependency on the dev branch of the code review tool, this is not critical for this ticket. If this gets merged then it will be part of the next release and we will benefit from the changes automatically in the future.

pfrenssen

When trying out the updated code review tool a number of coding standards violations are detected. These can also be fixed in scope of this PR.

voidtek · 2019-01-24T10:55:56Z

The PR change the permission file of tests/sandbox/.gitkeep 100644 → 100755.

voidtek

We should update the composer.json with the new branch of code-review.
I try in my local machine and these errors appears: (same of @pfrenssen )

devs-costvit:~/environment/task-runner (OPENEUROPA-1535) $ dckweb ./vendor/bin/grumphp run
GrumPHP is sniffing your code!
Running task 1/2: Phpcs... ✘
Running task 2/2: PhpMd... ✔
FILE: /var/www/html/src/Commands/AbstractCommands.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  37 | ERROR | [x] Expected at least 1 space before "."; 0 found
  37 | ERROR | [x] Expected at least 1 space after "."; 0 found
 118 | ERROR | [x] Expected at least 1 space before "."; 0 found
 118 | ERROR | [x] Expected at least 1 space after "."; 0 found
 118 | ERROR | [x] Expected at least 1 space before "."; 0 found
 118 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/src/Commands/AbstractDrupalCommands.php
----------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
  33 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
  34 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
  42 | ERROR | [x] Expected at least 1 space before "."; 0 found
  42 | ERROR | [x] Expected at least 1 space after "."; 0 found
  97 | ERROR | [x] Expected at least 1 space before "."; 0 found
  97 | ERROR | [x] Expected at least 1 space after "."; 0 found
 173 | ERROR | [x] Expected at least 1 space before "."; 0 found
 173 | ERROR | [x] Expected at least 1 space after "."; 0 found
 295 | ERROR | [x] Expected at least 1 space before "."; 0 found
 295 | ERROR | [x] Expected at least 1 space after "."; 0 found
 296 | ERROR | [x] Expected at least 1 space before "."; 0 found
 296 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/src/Commands/ChangelogCommands.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 23 | ERROR | [x] Expected at least 1 space before "."; 0 found
 23 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/src/Services/Composer.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 80 | ERROR | [x] Expected at least 1 space before "."; 0 found
 80 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/src/TaskRunner.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 144 | ERROR | [x] Expected at least 1 space before "."; 0 found
 144 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/src/Tasks/CollectionFactory/CollectionFactory.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------
 153 | ERROR | [x] Expected at least 1 space before "."; 0 found
 153 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/tests/AbstractTest.php
----------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 33 | ERROR | [x] Expected at least 1 space before "."; 0 found
 33 | ERROR | [x] Expected at least 1 space after "."; 0 found
 61 | ERROR | [x] Expected at least 1 space before "."; 0 found
 61 | ERROR | [x] Expected at least 1 space after "."; 0 found
 71 | ERROR | [x] Expected at least 1 space before "."; 0 found
 71 | ERROR | [x] Expected at least 1 space after "."; 0 found
 71 | ERROR | [x] Expected at least 1 space before "."; 0 found
 71 | ERROR | [x] Expected at least 1 space after "."; 0 found
 81 | ERROR | [x] Expected at least 1 space before "."; 0 found
 81 | ERROR | [x] Expected at least 1 space after "."; 0 found
 95 | ERROR | [x] Expected at least 1 space before "/"; 0 found
 95 | ERROR | [x] Expected at least 1 space after "/"; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/tests/Commands/ReleaseCommandsTest.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
  39 | ERROR | [x] Expected at least 1 space before "."; 0 found
  39 | ERROR | [x] Expected at least 1 space after "."; 0 found
  70 | ERROR | [x] Expected at least 1 space before "."; 0 found
  70 | ERROR | [x] Expected at least 1 space after "."; 0 found
 124 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 125 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 131 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 134 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 135 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
 140 | ERROR | [x] Object operator not indented correctly; expected
     |       |     12 spaces but found 10
----------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/tests/CommandsTest.php
----------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 14 LINES
----------------------------------------------------------------------
  59 | ERROR | [x] Expected at least 1 space before "."; 0 found
  59 | ERROR | [x] Expected at least 1 space after "."; 0 found
  92 | ERROR | [x] Expected at least 1 space before "."; 0 found
  92 | ERROR | [x] Expected at least 1 space after "."; 0 found
 129 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 130 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 131 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 132 | ERROR | [x] Array key not indented correctly; expected 12
     |       |     spaces but found 10
 153 | ERROR | [x] Expected at least 1 space before "."; 0 found
 153 | ERROR | [x] Expected at least 1 space after "."; 0 found
 198 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 199 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 249 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 250 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 304 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 305 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 12
 331 | ERROR | [x] Expected at least 1 space before "."; 0 found
 331 | ERROR | [x] Expected at least 1 space after "."; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/html/tests/Tasks/CollectionFactoryTest.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 56 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 57 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 58 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 59 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
 60 | ERROR | [x] Array key not indented correctly; expected 12
    |       |     spaces but found 10
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 1.02 secs; Memory: 10MB

You can fix some errors by running following command:
'/var/www/html/vendor/bin/phpcbf' '--standard=./vendor/openeuropa/code-review/resources/library-phpcs-ruleset.xml' '--report=full' '--warning-severity=0' '--ignore=vendor/,loadTasks.php' '/var/www/html/src/Commands/AbstractCommands.php' '/var/www/html/src/Commands/AbstractDrupalCommands.php' '/var/www/html/src/Commands/ChangelogCommands.php' '/var/www/html/src/Services/Composer.php' '/var/www/html/src/TaskRunner.php' '/var/www/html/src/Tasks/CollectionFactory/CollectionFactory.php' '/var/www/html/tests/AbstractTest.php' '/var/www/html/tests/Commands/ReleaseCommandsTest.php' '/var/www/html/tests/CommandsTest.php' '/var/www/html/tests/Tasks/CollectionFactoryTest.php'

drupol · 2019-01-24T16:14:51Z

Thanks for the commits @voidtek !

voidtek

The "operators spacing" changes are not requested on this ticket.

This repo is a library and we should follow the coding standard of Symfony.
https://symfony.com/doc/current/contributing/code/standards.html

Add a single space around binary operators (==, &&, ...), with the exception of the concatenation (.) operator;

drupol · 2019-01-30T15:12:11Z

Due to the conflicts with PHPCS rules, I opened a PR to revert those rules.

See: openeuropa/code-review#69

Has been fixed.

pfrenssen mentioned this pull request Jan 18, 2019

OPENEUROPA-1535: Coding style, fix indentation and concatenation. openeuropa/code-review#51

Merged

pfrenssen previously requested changes Jan 18, 2019

View reviewed changes

voidtek requested changes Jan 24, 2019

View reviewed changes

drupol force-pushed the OPENEUROPA-1535 branch 2 times, most recently from 6ff542d to 7840ea8 Compare January 30, 2019 12:05

voidtek requested changes Jan 30, 2019

View reviewed changes

drupol force-pushed the OPENEUROPA-1535 branch from 7840ea8 to 0b9cc3d Compare January 30, 2019 15:36

drupol mentioned this pull request Jan 30, 2019

OPENEUROPA-1569: Task-Runner: Add support in task-runner "process" task arrays (imploded to string with comma delimiter). #93

Merged

drupol force-pushed the OPENEUROPA-1535 branch from 0b9cc3d to 32ae956 Compare January 30, 2019 15:48

sergepavle previously approved these changes Jan 30, 2019

View reviewed changes

voidtek previously approved these changes Jan 30, 2019

View reviewed changes

drupol dismissed stale reviews from voidtek and sergepavle via 64d9955 January 30, 2019 15:55

drupol force-pushed the OPENEUROPA-1535 branch from 32ae956 to 64d9955 Compare January 30, 2019 15:55

sergepavle previously approved these changes Jan 30, 2019

View reviewed changes

drupol added 2 commits January 30, 2019 17:04

OPENEUROPA-1535: Enable patching via composer.json.

0236ac1

OPENEUROPA-1535: Update coding style based on new code-review version.

f499e96

drupol dismissed sergepavle’s stale review via f499e96 January 30, 2019 16:05

drupol force-pushed the OPENEUROPA-1535 branch from 64d9955 to f499e96 Compare January 30, 2019 16:05

voidtek approved these changes Jan 30, 2019

View reviewed changes

sergepavle approved these changes Jan 30, 2019

View reviewed changes

drupol merged commit 2aa63e4 into master Jan 30, 2019

drupol deleted the OPENEUROPA-1535 branch January 30, 2019 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OPENEUROPA-1535: Fix various coding style inconsistencies. #92

OPENEUROPA-1535: Fix various coding style inconsistencies. #92

drupol commented Jan 15, 2019

pfrenssen commented Jan 18, 2019

pfrenssen left a comment

voidtek commented Jan 24, 2019

voidtek left a comment •

edited

Loading

drupol commented Jan 24, 2019

voidtek left a comment

drupol commented Jan 30, 2019

OPENEUROPA-1535: Fix various coding style inconsistencies. #92

OPENEUROPA-1535: Fix various coding style inconsistencies. #92

Conversation

drupol commented Jan 15, 2019

pfrenssen commented Jan 18, 2019

pfrenssen left a comment

Choose a reason for hiding this comment

voidtek commented Jan 24, 2019

voidtek left a comment • edited Loading

Choose a reason for hiding this comment

drupol commented Jan 24, 2019

voidtek left a comment

Choose a reason for hiding this comment

drupol commented Jan 30, 2019

voidtek left a comment •

edited

Loading