Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 3rd party to add and alter the configuration #122

Merged
merged 19 commits into from
May 19, 2020
Merged

Allow 3rd party to add and alter the configuration #122

merged 19 commits into from
May 19, 2020

Conversation

claudiu-cristea
Copy link
Contributor

@claudiu-cristea claudiu-cristea commented Apr 22, 2020 •
edited
Loading

Fixes #121

@claudiu-cristea claudiu-cristea changed the title Allow 3rd party to alter the configuration Allow 3rd party to add and alter the configuration May 4, 2020
@claudiu-cristea claudiu-cristea mentioned this pull request May 4, 2020
Merged
pfrenssen
pfrenssen requested changes May 12, 2020
View reviewed changes
Copy link
Member

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good and necessary addition. Also a nice bonus command to list the compiled config 👍

src/TaskRunner.php Outdated Show resolved Hide resolved
src/Commands/RunnerCommands.php Outdated Show resolved Hide resolved
src/Commands/RunnerCommands.php Show resolved Hide resolved
src/TaskRunner.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/ConfigProviders/FileFromEnvironmentConfigProvider.php Outdated Show resolved Hide resolved
src/Contract/ConfigProviderInterface.php Outdated Show resolved Hide resolved
claudiu-cristea and others added 15 commits May 15, 2020 10:19
@claudiu-cristea
ISAICP-5825: Allow 3rd party to alter the configuration.
951ed28
@claudiu-cristea
ISAICP-5825: Rename the new method to comply with ::createConfigurati…
35f65c7 
…on().
@claudiu-cristea
ISAICP-5825: Add a command that returns the resolved config.
19c7ae2
@claudiu-cristea
ISAICP-5825: Switch to a discovery config altering.
75ff634
@claudiu-cristea
ISAICP-5825: Add documentation.
6acae8b
@claudiu-cristea
ISAICP-5825: Typos & wording improvements.
334ac9f
@claudiu-cristea
ISAICP-5825: Make sure that variables are resolved only at the end.
55b4a3c
@claudiu-cristea
ISAICP-5825: Init the working dir (was lost on refactoring).
008dfc2
@claudiu-cristea
ISAICP-5825: Fix some test docs. Remove unused statemenets.
8bff17f
@claudiu-cristea
ISAICP-5825: Use the Robo config class instead of manipulating arrays.
50a48f3
@claudiu-cristea
ISAICP-5825: Bump the Robo minimum version to avoid a config bug.
8eee721
@claudiu-cristea
ISAICP-5825: Allow the 'config' command to show a key.
d5bc78d
@claudiu-cristea
ISAICP-5825: Fix coding standards.
858ca06
@pfrenssen @claudiu-cristea
ISAICP-5825: Update documentation.
5a0aabc
@claudiu-cristea
ISAICP-5825: Use the generic discovery also for default config provid…
1ac9b1c 
…ers.
@claudiu-cristea
Copy link
Contributor Author

Fixed all remarks.

@idimopoulos idimopoulos merged commit c9a6d9a into master May 19, 2020
@idimopoulos idimopoulos deleted the custom-configs branch May 19, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idimopoulos idimopoulos idimopoulos approved these changes

@pfrenssen pfrenssen pfrenssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow 3rd party to alter the config
3 participants
@claudiu-cristea @pfrenssen @idimopoulos