This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject.xml and build.properties.
…backed-up anymore.
pfrenssen
reviewed
May 4, 2020
…g targets. Not used anymore.
The target still exists but no longer works and is replaced by a task runner command.
pfrenssen
suggested changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Most of the commands work flawless, and seeing the implementation of the task runner commands in YML files I can really now understand the benefit of it!
Fixed the QA reamrks. New successful build after fixing the QA remarks https://app.continuousphp.com/git-hub/ec-europa/joinup-dev/build/6fda3807-6b78-45d3-98a5-43a6a895875c |
pfrenssen
approved these changes
May 19, 2020
All looking good, ready to merge when this build is green: https://app.continuousphp.com/git-hub/ec-europa/joinup-dev/build/99873127-b887-429a-99a9-05798ddbf90a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT! This PR requires changes in the CPHP pipeline configuration. For this reason, the PR was tested in the
refs/heads/ISAICP-5825
pipeline. See the successful build 89265070-4575-45fe-a351-172ee5143e4e.Upstream PRs:
QA notes:
truncate-cache-tables
: Now, we skip the cache tables on backup, The following change has been made to the Jenkins job:empty-mysql-database
: This is accomplished now by the Drush command, part of thetoolkit:install-dump
.setup-acceptance
: Not used.rebuild-dev
: Not used.run-behat-tests
: Not used.provision-stack
: Not used.enable-uat-modules
: Not used.eulogin-ecas-mock-check-requirements
,eulogin-ecas-mock-image-download
,eulogin-ecas-mock-setup
,eulogin-ecas-mock-start
,eulogin-ecas-mock-stop
: Not used.setup-stage-file-proxy
,configure-stage-file-proxy
: Not used.clear-cache
: Use directly the Drush command../src/
. Some of them were wrongly placed under./scripts/
, but that is the place for command line/bash scripts. I've also fixed the namespace of the classes, from\DrupalProject\...
to\Joinup\...
../resources/codedeploy/
are dead code. Removed.build.dist.xml
intobuild.project.xml
andbuild.properties.dist
intobuild.properties
for simplicity. Otherwise this transition to Toolkit could be too expensive.setmysqlautoincrement
. It's a migration artefact.CPHP changes:
Build settings
Test settings (Behat & PHPUnit)
Created follow-ups