Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

cargo update -p eth-secp256k1 #11052

Merged
merged 1 commit into from
Sep 13, 2019
Merged

cargo update -p eth-secp256k1 #11052

merged 1 commit into from
Sep 13, 2019

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Sep 13, 2019 •
edited
Loading

To include paritytech/rust-secp256k1#19.

cd ethcore/verification; cargo bench --features=bench -- verify_block_unordered shows 1.75x speedup:

verify_block_unordered  time:   [17.404 ms 17.558 ms 17.720 ms]                                    
                        change: [-35.612% -35.041% -34.470%] (p = 0.00 < 0.05)
                        Performance has improved.

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M5-dependencies 🖇 Dependencies. labels Sep 13, 2019
@ordian ordian added this to the 2.7 milestone Sep 13, 2019
@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 13, 2019
@dvdplm dvdplm merged commit 0659cb8 into master Sep 13, 2019
@niklasad1 niklasad1 deleted the ao-update-libsecp256k1 branch September 13, 2019 17:48
dvdplm added a commit that referenced this pull request Sep 18, 2019
@dvdplm
Merge branch 'master' into dp/chore/new-ethereum-consensus-tests
1ab7ec6 
* master:
  [ethcore]: move client test types to test-helpers (#11062)
  [sync]: remove unused dependencies or make dev (#11061)
  [ethcore]: reduce re-exports (#11059)
  [evmbin] fix time formatting (#11060)
  Update hardcoded headers (foundation, classic, kovan,  xdai, ewc, ...) (#11053)
  cargo update -p eth-secp256k1 (#11052)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M5-dependencies 🖇 Dependencies.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ordian @dvdplm @niklasad1