Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[sync]: remove unused dependencies or make dev #11061

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

niklasad1
Copy link
Collaborator

cleanup dependencies in the sync crate

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Sep 16, 2019
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe now's a good time to convert –> edition 2018?

enum_primitive = "0.1.1"
ethcore = { path = ".." }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -14,7 +14,7 @@
// You should have received a copy of the GNU General Public License
// along with Parity Ethereum. If not, see <http://www.gnu.org/licenses/>.

#![warn(missing_docs)]
#![warn(missing_docs, unused_extern_crates)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ordian ordian added this to the 2.7 milestone Sep 16, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 16, 2019
@ordian ordian merged commit acad59b into master Sep 16, 2019
@ordian ordian deleted the na-sync-cleanup-dependencies branch September 16, 2019 19:56
@niklasad1
Copy link
Collaborator Author

Maybe now's a good time to convert –> edition 2018?

Yes, can be done in a follow-up PR and some other things...

dvdplm added a commit that referenced this pull request Sep 18, 2019
* master:
  [ethcore]: move client test types to test-helpers (#11062)
  [sync]: remove unused dependencies or make dev (#11061)
  [ethcore]: reduce re-exports (#11059)
  [evmbin] fix time formatting (#11060)
  Update hardcoded headers (foundation, classic, kovan,  xdai, ewc, ...) (#11053)
  cargo update -p eth-secp256k1 (#11052)
@niklasad1 niklasad1 mentioned this pull request Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants