This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[sync]: remove unused dependencies or make dev #11061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A0-pleasereview 🤓
Pull request needs code review.
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
M4-core ⛓
Core client code / Rust.
labels
Sep 16, 2019
dvdplm
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe now's a good time to convert –> edition 2018?
enum_primitive = "0.1.1" | ||
ethcore = { path = ".." } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -14,7 +14,7 @@ | |||
// You should have received a copy of the GNU General Public License | |||
// along with Parity Ethereum. If not, see <http://www.gnu.org/licenses/>. | |||
|
|||
#![warn(missing_docs)] | |||
#![warn(missing_docs, unused_extern_crates)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ordian
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Sep 16, 2019
ordian
approved these changes
Sep 16, 2019
Yes, can be done in a follow-up PR and some other things... |
dvdplm
added a commit
that referenced
this pull request
Sep 18, 2019
* master: [ethcore]: move client test types to test-helpers (#11062) [sync]: remove unused dependencies or make dev (#11061) [ethcore]: reduce re-exports (#11059) [evmbin] fix time formatting (#11060) Update hardcoded headers (foundation, classic, kovan, xdai, ewc, ...) (#11053) cargo update -p eth-secp256k1 (#11052)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
A8-looksgood 🦄
Pull request is reviewed well.
M4-core ⛓
Core client code / Rust.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup dependencies in the
sync
crate