Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avro: add recipe for c++ #807

Closed

Conversation

RuiMarioCosta
Copy link

  • remove the unittests from the compilation step
  • add cmake configuration files to use with find_package

@kraj
Copy link
Contributor

kraj commented Apr 3, 2024

ERROR: avro-c++-1.11.3-r0 do_populate_lic: QA Issue: avro-c++: The LIC_FILES_CHKSUM does not match for file://LICENSE;md5=6d502b41f76179fc
84e536236f359cae
avro-c++: The new md5 checksum is 43abf34d8b9908494f83c55d213a7f89

Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the license checksum errors.

@shr-project
Copy link
Contributor

And add Upstream-Status into the .patch files.

@RuiMarioCosta RuiMarioCosta requested a review from kraj April 4, 2024 16:18
@kraj
Copy link
Contributor

kraj commented Apr 4, 2024

compile errors with clang compiler

 | FAILED: CMakeFiles/avrocpp.dir/impl/json/JsonIO.cc.o
    | /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/recipe-sysroot-native/usr/bin/x86_64-poky-linux/x86_64-poky-linux-g++ --sysr
    | In file included from /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/recipe-sysroot/usr/include/boost/math/tools/real_cast.
    |                  from /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/recipe-sysroot/usr/include/boost/math/special_function
    |                  from /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/git/lang/c++/impl/json/JsonIO.hh:23,
    |                  from /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/git/lang/c++/impl/json/JsonIO.cc:19:
    | /home/pokybuild/yocto-worker/meta-oe/build/build/tmp/work/core2-64-poky-linux/avro-c++/1.11.3/recipe-sysroot/usr/include/boost/math/tools/config.hpp:23:6: error: #warning
    |    23 | #    warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)"
    |       |      ^~~~~~~
    | cc1plus: all warnings being treated as errors
 

@kraj
Copy link
Contributor

kraj commented Apr 4, 2024

and squash commits into a single commit for clean commit history

- remove the unittests from the compilation step
- add cmake configuration files to use with find_package
- update c++ version to 14
@RuiMarioCosta
Copy link
Author

Hello @kraj can you please review again?

@kraj
Copy link
Contributor

kraj commented Apr 8, 2024

looks ok. Merged with 1db8a43

@kraj kraj closed this Apr 8, 2024
@shr-project
Copy link
Contributor

shr-project commented Apr 9, 2024

@RuiMarioCosta It fails to build with multilib enabled as it doesn't respect libdir setting

ERROR: QA Issue: avro-c++: Files/directories were installed but not shipped in any package:
  /usr/lib/libavrocpp.so
  /usr/lib/libavrocpp.so.1.11.3
  /usr/lib/cmake
  /usr/lib/cmake/avrocpp
  /usr/lib/cmake/avrocpp/AvroCppTargets-release.cmake
  /usr/lib/cmake/avrocpp/AvroCppConfig.cmake
  /usr/lib/cmake/avrocpp/AvroCppTargets.cmake
  /usr/lib/cmake/avrocpp/AvroCppConfigVersion.cmake
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
avro-c++: 8 installed and not shipped files. [installed-vs-shipped]

@shr-project
Copy link
Contributor

shr-project commented Apr 9, 2024

@RuiMarioCosta And the HOMEPAGE = "http://apr.apache.org/" also seems copy&paste from apr recipe (instead of https://avro.apache.org/)

thomas-roos pushed a commit to thomas-roos/meta-openembedded that referenced this pull request May 2, 2024
This release contains bug fixes only.
The following CVEs have been addressed:

CVE-2023-27783
CVE-2023-27784
CVE-2023-27785
CVE-2023-27786
CVE-2023-27787
CVE-2023-27788
CVE-2023-27789

Changelog:
=========
dlt_jnpr_ether_cleanup: check subctx before cleanup by @Marsman1996 in openembedded#781
Bug openembedded#780 assert tcpedit dlt cleanup by @fklassen in openembedded#800
Fix bugs caused by strtok_r by @Marsman1996 in openembedded#783
Bug openembedded#782 openembedded#784 openembedded#785 openembedded#786 openembedded#787 openembedded#788 strtok r isuses by @fklassen in openembedded#801
Update en10mb.c by @david-guti in openembedded#793
PR openembedded#793 ip6 unicast flood by @fklassen in openembedded#802
Bug openembedded#719 fix overflow check for parse_mpls() by @fklassen in openembedded#804
PR openembedded#793 - update tests for corrected IPv6 MAC by @fklassen in openembedded#805
PR openembedded#793 - update tests for vlandel by @fklassen in openembedded#806
Feature openembedded#773 gh actions ci by @fklassen in openembedded#807
Feature openembedded#759: Upgrade autogen/libopts to 5.18.16 by @fklassen in openembedded#760
Bug openembedded#751 don't exit after send error by @fklassen in openembedded#761
Bug openembedded#750: configure: libpcap version robustness by @fklassen in openembedded#764
Bug openembedded#749 flow stats: avoid overstating flow packet count by @fklassen in openembedded#765
Bug openembedded#750 more libpcap version updates by @fklassen in openembedded#766
Bug openembedded#767 tests: support for out-of-tree tests by @fklassen in openembedded#768
Bug openembedded#750 - fix macOS test failure by @fklassen in openembedded#770
4.4.3 by @fklassen in openembedded#769 and openembedded#771

Signed-off-by: Archana Polampalli <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Nov 6, 2024
Changelog:
===========
- Fixed regression caused by (openembedded#807) that prevented the use of parametrized async fixtures
- Fixed TaskGroup and CancelScope producing cyclic references in tracebacks when raising exceptions

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants