Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: python3-twisted on Kirkstone is missing two runtime dependencies #805

Closed
gudnimg opened this issue Apr 2, 2024 · 3 comments
Closed

Comments

@gudnimg
Copy link
Contributor

gudnimg commented Apr 2, 2024

I noticed when upgrading a project to Kirkstone that Twisted 22.2.0 is missing two runtime dependencies which were later added with these following commits, but haven't been backported:

I currently have a bbappend file in my project to resolve this, but it would be nice to fix the Kirkstone LTS branch.

Adding python3-typing-extensions and python3-asyncio to RDEPENDS:${PN}-core should resolve the issue. Minimum requirement for python3-typing-extensions is 3.6.5, and the OpenEmbedded recipe provides version 3.10.0.0 ✔️

I can try submit a patch for this, but wanted to ask first if a fix like this is considered for merging? This is merely just to fix the recipe upstream.

@kraj
Copy link
Contributor

kraj commented Apr 3, 2024

@gudnimg thanks for report and yes this is a good fix for stable branch, please check with master branch first and if its not fixed there, then propose it for master, if its already fixed in master via another commit then backport that to stable branch, if not backportable, then modify the fix suitable for stable branch

@gudnimg
Copy link
Contributor Author

gudnimg commented Apr 3, 2024

if its already fixed in master via another commit then backport that to stable branch

These two commits are in master:

I’m not sure about the best approach to send this via the mailing list (still learning 😀). Do I just cherry pick these on a local kirkstone branch and sign the commits like I would regular commits?

@gudnimg
Copy link
Contributor Author

gudnimg commented Apr 3, 2024

On an unrelated note, I would love to backport these two commits as well (they’re from me BTW). They are not critical, but cleaning dependencies is really importart for my application to minimize image size (pip is ~10MB)

But I will focus on twisted first since it causes an actual error. 😊

@gudnimg gudnimg closed this as completed Apr 3, 2024
thomas-roos pushed a commit to thomas-roos/meta-openembedded that referenced this issue May 2, 2024
This release contains bug fixes only.
The following CVEs have been addressed:

CVE-2023-27783
CVE-2023-27784
CVE-2023-27785
CVE-2023-27786
CVE-2023-27787
CVE-2023-27788
CVE-2023-27789

Changelog:
=========
dlt_jnpr_ether_cleanup: check subctx before cleanup by @Marsman1996 in openembedded#781
Bug openembedded#780 assert tcpedit dlt cleanup by @fklassen in openembedded#800
Fix bugs caused by strtok_r by @Marsman1996 in openembedded#783
Bug openembedded#782 openembedded#784 openembedded#785 openembedded#786 openembedded#787 openembedded#788 strtok r isuses by @fklassen in openembedded#801
Update en10mb.c by @david-guti in openembedded#793
PR openembedded#793 ip6 unicast flood by @fklassen in openembedded#802
Bug openembedded#719 fix overflow check for parse_mpls() by @fklassen in openembedded#804
PR openembedded#793 - update tests for corrected IPv6 MAC by @fklassen in openembedded#805
PR openembedded#793 - update tests for vlandel by @fklassen in openembedded#806
Feature openembedded#773 gh actions ci by @fklassen in openembedded#807
Feature openembedded#759: Upgrade autogen/libopts to 5.18.16 by @fklassen in openembedded#760
Bug openembedded#751 don't exit after send error by @fklassen in openembedded#761
Bug openembedded#750: configure: libpcap version robustness by @fklassen in openembedded#764
Bug openembedded#749 flow stats: avoid overstating flow packet count by @fklassen in openembedded#765
Bug openembedded#750 more libpcap version updates by @fklassen in openembedded#766
Bug openembedded#767 tests: support for out-of-tree tests by @fklassen in openembedded#768
Bug openembedded#750 - fix macOS test failure by @fklassen in openembedded#770
4.4.3 by @fklassen in openembedded#769 and openembedded#771

Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants