Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recently added PEP8 violations #6063

Merged
merged 4 commits into from
Nov 27, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/djangoapps/third_party_auth/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ def parse_query_params(strategy, response, *args, **kwargs):
'is_register_2': auth_entry == AUTH_ENTRY_REGISTER_2,
}


# TODO (ECOM-369): Once the A/B test of the combined login/registration
# form completes, we will be able to remove the extra login/registration
# end-points. HOWEVER, users who used the new forms during the A/B
Expand Down
1 change: 1 addition & 0 deletions common/djangoapps/user_api/api/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

log = logging.getLogger(__name__)


class ProfileRequestError(Exception):
""" The request to the API was not valid. """
pass
Expand Down
2 changes: 0 additions & 2 deletions common/djangoapps/user_api/tests/test_profile_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ def test_change_email_optin(self, age, option, second_option, expected_result):
result_obj = UserOrgTag.objects.get(user=user, org=course.id.org, key='email-optin')
self.assertEqual(result_obj.value, expected_result)



@raises(profile_api.ProfileUserNotFound)
def test_retrieve_and_update_preference_info_no_user(self):
preferences = profile_api.preference_info(self.USERNAME)
Expand Down
2 changes: 2 additions & 0 deletions common/test/acceptance/pages/lms/instructor_dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class InstructorDashboardPage(CoursePage):
Instructor dashboard, where course staff can manage a course.
"""
url_path = "instructor"

def is_browser_on_page(self):
return self.q(css='div.instructor-dashboard-wrapper-2').present

Expand All @@ -31,6 +32,7 @@ class MembershipPage(PageObject):
Membership section of the Instructor dashboard.
"""
url = None

def is_browser_on_page(self):
return self.q(css='a[data-section=membership].active-section').present

Expand Down
2 changes: 1 addition & 1 deletion scripts/all-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ set -e

# Violations thresholds for failing the build
PYLINT_THRESHOLD=4600
PEP8_THRESHOLD=5
PEP8_THRESHOLD=0

source $HOME/jenkins_env

Expand Down