-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recently added PEP8 violations #6063
Conversation
Thanks for the pull request, @stvstnfrd! I've created OSPR-237 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here. |
7d684b3
to
03b5c71
Compare
w0rd. Although there may be a bug in the violations script you need to address - perhaps the quality build is failing because it is a "<" rather than "<="? Ping me when it's good and I'll take a final look. |
1be294e
to
055faf3
Compare
055faf3
to
edb6c16
Compare
@sarina The quality test is passing again. It turned out that someone |
how is that possible with diff-quality!?!? Will merge if/when build passes. Thanks! |
Yeah, I don't know either, but I'm looking at it, clear as day [1]. Aren't test failures just a "suggestion" and not actually a blocker on Anyway, tests are passing. |
Fix recently added PEP8 violations
😍 |
These violations were introduced recently, after we had removed all
instances of these violations. As of now, these represent the final PEP8
violations.
This PR also drops the PEP8 threshold down to zero violations (!!!), so
it will need to be merged after #6045 lands.