Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recently added PEP8 violations #6063

Merged
merged 4 commits into from
Nov 27, 2014
Merged

Conversation

stvstnfrd
Copy link
Contributor

These violations were introduced recently, after we had removed all
instances of these violations. As of now, these represent the final PEP8
violations.

This PR also drops the PEP8 threshold down to zero violations (!!!), so
it will need to be merged after #6045 lands.

@openedx-webhooks
Copy link

Thanks for the pull request, @stvstnfrd! I've created OSPR-237 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

@sarina
Copy link
Contributor

sarina commented Nov 26, 2014

w0rd. Although there may be a bug in the violations script you need to address - perhaps the quality build is failing because it is a "<" rather than "<="? Ping me when it's good and I'll take a final look.

@stvstnfrd
Copy link
Contributor Author

@sarina The quality test is passing again. It turned out that someone
else had snuck 2 more PEP8 violations into the code while this PR was
in flight.

@sarina
Copy link
Contributor

sarina commented Nov 26, 2014

how is that possible with diff-quality!?!? Will merge if/when build passes. Thanks!

@stvstnfrd
Copy link
Contributor Author

Yeah, I don't know either, but I'm looking at it, clear as day [1].

Aren't test failures just a "suggestion" and not actually a blocker on
merge? Too bad we don't have commit hooks...

Anyway, tests are passing.

[1] https://github.com/edx/edx-platform/pull/6073/files#diff-35e1eec9376ca44d4faa41efb1d32750R178

sarina added a commit that referenced this pull request Nov 27, 2014
Fix recently added PEP8 violations
@sarina sarina merged commit 17aa898 into openedx:master Nov 27, 2014
@jzoldak
Copy link
Contributor

jzoldak commented Nov 27, 2014

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants