Added testing for grading settings #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note that 2 tests will not reliably work: Deleting a grade- Was able to circumvent this with javascript Moving the grade slider- Could not circumvent, is skipped but the framework is in place
|
I think it makes more sense for @dmitchell to review this pull request. Don wrote the grading settings page, and it would be helpful for him to be familiar with the test (for future features/maintenance). |
|
I have no way to test this w/ my env as it stands. I guess it looks roughly right. |
|
👍 |
JonahStanley
pushed a commit
that referenced
this pull request
Jun 20, 2013
Added testing for grading settings
chrisrossi
referenced
this pull request
in jazkarta/edx-platform
Mar 31, 2014
modify capa_problem to add <include file="foo"> functionality
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Jul 16, 2014
…-api-doc Sessions module api doc
iamjazzar
pushed a commit
to iamjazzar/edx-platform
that referenced
this pull request
Nov 4, 2015
Adding missing string ("Want to change your account settings?") to edraak-platform.
clemente
pushed a commit
to edx-olive-oc/edx-platform
that referenced
this pull request
May 1, 2018
…1-campus/CAM-5 Hint username with SAML integration
dvorgbe
pushed a commit
to aludeveloper/edx-platform
that referenced
this pull request
Aug 14, 2018
Fix S3 grades for AWS Signature Versions 4 endpoints.
prabhanshu
pushed a commit
to prabhanshu/edx-platform
that referenced
this pull request
Oct 13, 2018
identical to PR openedx#113 * Adds support for objuscating last two octets of ip address in tracking logs * Cleaning up change * Fixing a couple edge case events * live oauth support (openedx#115) * Added settings import to fix tests * Fixes tests * Remove vscode folder * Fixing quality errors * simpler obfuscation method * cleanup2 simpler pr template (openedx#130) * simpler pr template * more accurate phrasing * more specific phrasing
prabhanshu
pushed a commit
to prabhanshu/edx-platform
that referenced
this pull request
Oct 13, 2018
identical to PR openedx#138 * live oauth support (openedx#115) * Fixing codecov * Fixing shared reports folder * Running paver coverage before codecov * Fix travis reporting script * Upping codecov threshold to reflect current state
prabhanshu
pushed a commit
to prabhanshu/edx-platform
that referenced
this pull request
Oct 13, 2018
identical to PR openedx#132 * live oauth support (openedx#115) * Updated message for Certificates * Update test_views.py (cherry picked from commit ab88963)
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
I find it much more legible this way. Some thoughts… as part of refactoring it, I made some of the redux selectors more formal, and made use of reselect more thoroughly. this resulted in a reduction in re-renders from 16 to 12 on your average page load. It’s also a bit more verbose, accounting for some of the increased line count. I hadn’t tried it before, but found the memoize method of comparing previous props/state to current props/state to be very, very nice. Much easier than manually comparing props, and much clearer to me than using react hooks’ dependency arrays. The lack of dependency arrays feels really freeing in general to me. They’ve been such a source of hard-to-track-down bugs, and the hooks linter does not always suggest the right solution for what belongs in and out of the array. Function names are nice. We had a ton of custom hooks in there so that we could put names to otherwise anonymous bits of functionality. Also note: this component has a test suite. It passed without any changes. 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested Reviewers: Studio team dev, @jzoldak
These tests test the grading settings:
Specifically, the ability to add/delete/change grading ranges and the ability to add/delete/change grading types.
The ability to add/create/delete grading types was also checked to make sure it propagates to the subsection types.
Please note that 2 tests will not reliably work:
Deleting a grade- Was able to circumvent this with javascript
Moving the grade slider- Could not circumvent, is skipped but the framework is in place