-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will/jenkins diff cover #113
Conversation
Git doesn't treat revisions differently than branches, so I'm not sure why creating a local branch would matter in this case. In particular, on my machine, |
Can you actually just do a rebase and remove both eed66 and c7af1 from the history entirely? (Assuming that it works w/o them) |
@cpennington After further experimentation, I agree with you. The change was in response to some strangeness I was seeing in Jenkins (lots of extra commits showing up in I want to get this merged, then watch the diff coverage HTML report to see if there are edge cases with |
to `origin/master` instead of `master`)
👍, shipit |
👍 |
…pletion-leaders course completions leaderboard
Fix calculator info and `=` icons
7d21ef048f528bf98958904f6bb9f5c5fc253bf3 Updated CPU and memory recommendations 25a1102a74ffb4ac3d054ed5cac76a94fdeb9c7b Added troubleshooting section to README
identical to PR openedx#113 * Adds support for objuscating last two octets of ip address in tracking logs * Cleaning up change * Fixing a couple edge case events * live oauth support (openedx#115) * Added settings import to fix tests * Fixes tests * Remove vscode folder * Fixing quality errors * simpler obfuscation method * cleanup2 simpler pr template (openedx#130) * simpler pr template * more accurate phrasing * more specific phrasing
This PR updates
diff-cover
version 0.1.1, which usesgit diff origin/master...HEAD
instead ofgit diff master...HEAD
. Since the localmaster
branch is not always current in Jenkins, this ensures that we're comparing to the most recent version ofmaster
.Suggested reviewers: @jzoldak @cpennington