feat(filter): add support to use unused partitions in os-disk

changelogs/unreleased/524-akhilerm

@@ -0,0 +1 @@
+add support for creating blockdevices for unused os-disk partitions

cmd/ndm_daemonset/filter/osdiskexcludefilter.go

@@ -90,7 +90,6 @@ func (odf *oSDiskExcludeFilter) Start() {
 		mountPointUtil := mount.NewMountUtil(hostMountFilePath, "", mountPoint)
 		if devPath, err := mountPointUtil.GetDiskPath(); err != nil {
 			klog.Errorf("unable to configure os disk filter for mountpoint: %s, error: %v", mountPoint, err)
-			klog.Error(err)
 		} else {
 			odf.excludeDevPaths = append(odf.excludeDevPaths, devPath)
 		}
@@ -103,7 +102,6 @@ func (odf *oSDiskExcludeFilter) Start() {
 		mountPointUtil := mount.NewMountUtil(defaultMountFilePath, "", mountPoint)
 		if devPath, err := mountPointUtil.GetDiskPath(); err != nil {
 			klog.Errorf("unable to configure os disk filter for mountpoint: %s, error: %v", mountPoint, err)
-			klog.Error(err)
 		} else {
 			odf.excludeDevPaths = append(odf.excludeDevPaths, devPath)
 		}

pkg/features/features.go

@@ -41,21 +41,26 @@ const (
 	// blockdevice UUID algorithm mentioned in
 	// https://github.com/openebs/openebs/pull/2666
 	GPTBasedUUID Feature = "GPTBasedUUID"
+
 	// APIService feature flag starts the GRPC server which provides functionality to manage block devices
 	APIService Feature = "APIService"
+
+	UseOSDisk Feature = "UseOSDisk"
 )
 
 // supportedFeatures is the list of supported features. This is used while parsing the
 // feature flag given via command line
 var supportedFeatures = []Feature{
 	GPTBasedUUID,
 	APIService,
+	UseOSDisk,
 }
 
 // defaultFeatureGates is the default features that will be applied to the application
 var defaultFeatureGates = map[Feature]bool{
 	GPTBasedUUID: false,
 	APIService:   false,
+	UseOSDisk:    false,
 }
 
 // featureFlag is a map representing the flag and its state

pkg/mount/mountutil.go

@@ -19,6 +19,7 @@ package mount
 import (
 	"bufio"
 	"fmt"
+	"github.com/openebs/node-disk-manager/pkg/features"
 	"io"
 	"os"
 	"path/filepath"
@@ -116,11 +117,22 @@ func getDiskDevPath(partition string) (string, error) {
 		return "", err
 	}
 
-	parentDisk, ok := getParentBlockDevice(link)
-	if !ok {
-		return "", fmt.Errorf("could not find parent device for %s", link)
+	var disk string
+	var ok bool
+	if features.FeatureGates.IsEnabled(features.UseOSDisk) {
+		// the last part will be used instead of the parent disk
+		// eg: /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda4 is the link
+		// and sda4 will be the device.
+		split := strings.Split(link, "/")
+		disk = split[len(split)-1]
+	} else {
+		disk, ok = getParentBlockDevice(link)
+		if !ok {
+			return "", fmt.Errorf("could not find parent device for %s", link)
+		}
 	}
-	return "/dev/" + parentDisk, nil
+
+	return "/dev/" + disk, nil
 }
 
 //	getSoftLinkForPartition returns path to /sys/class/block/$partition