Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add support to use unused partitions in os-disk #524

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Dec 29, 2020

Why is this PR required? What issue does it fix?:
Sometimes the nodes may have only one large disk with many partitions. NDM currently ignores the complete disk if it contains a system partition. This PR adds support to create blockdevice resources from the unused partitions on the OS disk.

What this PR does?:

  • adds a new feature gate to enable / disable using OS disk for blockdevices
  • modify the os disk filter to exclude only the partition that contains the system mountpoints and not the entire disk

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Signed-off-by: Akhil Mohan <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #524 (35a70d4) into master (85c8faa) will decrease coverage by 0.05%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   47.87%   47.82%   -0.06%     
==========================================
  Files          73       73              
  Lines        3348     3352       +4     
==========================================
  Hits         1603     1603              
- Misses       1584     1586       +2     
- Partials      161      163       +2     
Impacted Files Coverage Δ
cmd/ndm_daemonset/filter/osdiskexcludefilter.go 74.35% <ø> (-1.26%) ⬇️
pkg/features/features.go 100.00% <ø> (ø)
pkg/mount/mountutil.go 72.00% <45.45%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c8faa...35a70d4. Read the comment docs.

@akhilerm akhilerm removed the pr/hold-review Needs rework. label Dec 31, 2020
@akhilerm akhilerm requested a review from kmova December 31, 2020 06:14
Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm requested a review from kmova January 5, 2021 15:35
@kmova kmova merged commit 8b7a583 into openebs-archive:master Jan 6, 2021
@akhilerm akhilerm deleted the use-os-disk branch December 13, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for partitions in NDM os disk filter
3 participants