-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter): add support to use unused partitions in os-disk #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilerm
force-pushed
the
use-os-disk
branch
from
December 29, 2020 07:07
b7f6911
to
34279ca
Compare
Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
use-os-disk
branch
from
December 30, 2020 06:58
0aac93e
to
cd9680f
Compare
Signed-off-by: Akhil Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 47.87% 47.82% -0.06%
==========================================
Files 73 73
Lines 3348 3352 +4
==========================================
Hits 1603 1603
- Misses 1584 1586 +2
- Partials 161 163 +2
Continue to review full report at Codecov.
|
kmova
reviewed
Jan 5, 2021
kmova
reviewed
Jan 5, 2021
Signed-off-by: Akhil Mohan <[email protected]>
kmova
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Sometimes the nodes may have only one large disk with many partitions. NDM currently ignores the complete disk if it contains a system partition. This PR adds support to create blockdevice resources from the unused partitions on the OS disk.
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>