Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spc): Fix the test related to the PR #1597 #1602

Merged

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#2855

Special notes for your reviewer:

Checklist:

  • Fixes
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: chandan kumar [email protected]

@chandankumar4 chandankumar4 changed the title test(spc): Fix the test related to the PR #1597 [WIP] test(spc): Fix the test related to the PR #1597 Feb 2, 2020
@chandankumar4 chandankumar4 changed the title [WIP] test(spc): Fix the test related to the PR #1597 test(spc): Fix the test related to the PR #1597 Feb 2, 2020
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good. We need to add more for testing new feature. For ex., without these changes also, travis passed, but, ideally it should have failed if testcases are taken care of this overprovisioning feature properly.

@vishnuitta vishnuitta merged commit fdf8a59 into openebs-archive:master Feb 2, 2020
@chandankumar4 chandankumar4 deleted the thickprovisioning-test branch February 2, 2020 15:27
@kmova kmova added this to the 1.7.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to disable over provisioning on cStor Pools
3 participants