chore(spc):introduce new field to control overprovisioning #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chandan kumar <[email protected]>
sonasingh46
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
lgtm
Upgrade changes are covered.
No upgrade changes required. cc @shubham14bajpai
chandankumar4
added a commit
to chandankumar4/maya
that referenced
this pull request
Feb 2, 2020
Signed-off-by: chandan kumar <[email protected]>
9 tasks
vishnuitta
pushed a commit
that referenced
this pull request
Feb 2, 2020
Signed-off-by: chandan kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR added support to restrict overprovisioning of volumes on a cStor pool. Please go through the following links to understand more.
#1577
openebs/openebs#2855
SPC has a field
overProvisioningthat was never used and the PR made use of that to decide on overprovisioning requirements.Now every existing SPC might have SPC created with missing
overProvisioningfield(the missing field will have by default a false value as the field is of bool type) or value set to false.Now, there can be failure in subsequent volume provisioning if a user intends to over-provision -- to fix this one would need to edit SPC yaml to turn
overProvisioningto true.This PR introduces a new field
thickProvisoningto decide on over-provisioning requirements and the fieldoverProvisioningin SPC is deprecated and will cause no impact.thickProvisoningis set to true -- overprovisioning is disabled.thickProvisoningis set to false -- overprovisioning is enabled.Signed-off-by: chandan kumar [email protected]
Special notes for your reviewer:
Dependent PR: openebs/openebs#2901
This PR needs to merge first in order to travis CI to pass for the PR.