-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cspi): add timeout seconds in zfs cmd used for liveness probe and safe-evict annotation on CSP #1546
Merged
vishnuitta
merged 1 commit into
openebs-archive:master
from
prateekpandey14:add-timeout-and-safe-to-evict
Dec 11, 2019
Merged
fix(cspi): add timeout seconds in zfs cmd used for liveness probe and safe-evict annotation on CSP #1546
vishnuitta
merged 1 commit into
openebs-archive:master
from
prateekpandey14:add-timeout-and-safe-to-evict
Dec 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
added
the
pr/upgrade-changes-pending
This PR requires upgrade changes to be automated
label
Dec 11, 2019
prateekpandey14
force-pushed
the
add-timeout-and-safe-to-evict
branch
from
December 11, 2019 09:42
b0518ff
to
a0c746b
Compare
9 tasks
prateekpandey14
changed the title
fix(csp): add timeout seconds in zfs cmd used for liveness probe
fix(cspi): add timeout seconds in zfs cmd used for liveness probe
Dec 11, 2019
kmova
reviewed
Dec 11, 2019
prateekpandey14
force-pushed
the
add-timeout-and-safe-to-evict
branch
from
December 11, 2019 10:32
a0c746b
to
c24bcbc
Compare
9 tasks
prateekpandey14
force-pushed
the
add-timeout-and-safe-to-evict
branch
from
December 11, 2019 12:43
c24bcbc
to
9581e52
Compare
sonasingh46
changed the title
fix(cspi): add timeout seconds in zfs cmd used for liveness probe
fix(cspi): add timeout seconds in zfs cmd used for liveness probe and safe-evict annotation on CSP
Dec 11, 2019
kmova
approved these changes
Dec 11, 2019
mittachaitu
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
prateekpandey14
force-pushed
the
add-timeout-and-safe-to-evict
branch
from
December 11, 2019 12:50
9581e52
to
5fe42f2
Compare
- add 120 seconds cmd timeout value for zfs command which will kill the cmd process if it exceeds more than 120 seconds and returns non-zero exit status. - Change Probe timeout seconds to 150 seconds. - Change PeriodSeconds interval to 60 seconds. - add safe-to-evict to false to disable scaledown for CSP pods Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
add-timeout-and-safe-to-evict
branch
from
December 11, 2019 12:52
5fe42f2
to
2d73070
Compare
prateekpandey14
added a commit
to prateekpandey14/maya
that referenced
this pull request
Dec 11, 2019
…enebs-archive#1546) - add 120 seconds cmd timeout value for zfs command which will kill the cmd process if it exceeds more than 120 seconds and returns non-zero exit status. - Change Probe timeout seconds to 150 seconds. - Change PeriodSeconds interval to 60 seconds. - add safe-to-evict to false to disable scaledown for CSP pods Signed-off-by: prateekpandey14 <[email protected]>
kmova
pushed a commit
that referenced
this pull request
Dec 11, 2019
) - add 120 seconds cmd timeout value for zfs command which will kill the cmd process if it exceeds more than 120 seconds and returns non-zero exit status. - Change Probe timeout seconds to 150 seconds. - Change PeriodSeconds interval to 60 seconds. - add safe-to-evict to false to disable scaledown for CSP pods Signed-off-by: prateekpandey14 <[email protected]>
shubham14bajpai
pushed a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 27, 2019
…enebs-archive#1546) - add 120 seconds cmd timeout value for zfs command which will kill the cmd process if it exceeds more than 120 seconds and returns non-zero exit status. - Change Probe timeout seconds to 150 seconds. - Change PeriodSeconds interval to 60 seconds. - add safe-to-evict to false to disable scaledown for CSP pods Signed-off-by: prateekpandey14 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
kill the cmd process if it exceeds more than 120 seconds and
returns non-zero exit status.
Signed-off-by: prateekpandey14 [email protected]