fix(cstor-pool-mgmt): fix livenessprobe in cStor pool deployment #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
added
the
pr/upgrade-changes-pending
mittachaitu
requested review from
kmova,
prateekpandey14,
sonasingh46 and
vishnuitta
mittachaitu
changed the title
vishnuitta
reviewed
Dec 10, 2019
|
@singhmeghna79 would you be able to review this change and also try out if possible? |
9 tasks
mynktl
approved these changes
Dec 11, 2019
singhmeghna79
approved these changes
Dec 11, 2019
Signed-off-by: mittachaitu <[email protected]>
mynktl
approved these changes
Dec 11, 2019
|
A similar fix needs to be propagated to the cspi mgmt YAML spec that can be done in a separate PR. |
kmova
reviewed
Dec 11, 2019
added 2 commits
December 11, 2019 16:48
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
Handled in PR #1546 |
kmova
approved these changes
Dec 11, 2019
prateekpandey14
approved these changes
Dec 11, 2019
prateekpandey14
pushed a commit
to prateekpandey14/maya
that referenced
this pull request
Dec 11, 2019
…nebs-archive#1544) This PR fixes the liveness probe on cstor-pool container by adding `timeout` setting for command execution(run a command with a time limit). `timeout` will be helpful in a case when the disks are detached from the node and when liveness triggers command(zfs set... command) it will be hung forever and kubelet will not treat them as a failures. Kubelet also retries execute the same command after timeoutSeconds mentioned in the liveness probe. By triggering timeout 120 zfs set io.openebs:livenesstimestamp="$(date +%s)" cstor-<pool_name> will kill the process if it exceeds more than 120 seconds and returns non-zero exit status. Signed-off-by: mittachaitu <[email protected]>
kmova
pushed a commit
that referenced
this pull request
Dec 11, 2019
This PR fixes the liveness probe on cstor-pool container by adding `timeout` setting for command execution(run a command with a time limit). `timeout` will be helpful in a case when the disks are detached from the node and when liveness triggers command(zfs set... command) it will be hung forever and kubelet will not treat them as a failures. Kubelet also retries execute the same command after timeoutSeconds mentioned in the liveness probe. By triggering timeout 120 zfs set io.openebs:livenesstimestamp="$(date +%s)" cstor-<pool_name> will kill the process if it exceeds more than 120 seconds and returns non-zero exit status. Signed-off-by: mittachaitu <[email protected]>
shubham14bajpai
pushed a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 27, 2019
…nebs-archive#1544) This PR fixes the liveness probe on cstor-pool container by adding `timeout` setting for command execution(run a command with a time limit). `timeout` will be helpful in a case when the disks are detached from the node and when liveness triggers command(zfs set... command) it will be hung forever and kubelet will not treat them as a failures. Kubelet also retries execute the same command after timeoutSeconds mentioned in the liveness probe. By triggering timeout 120 zfs set io.openebs:livenesstimestamp="$(date +%s)" cstor-<pool_name> will kill the process if it exceeds more than 120 seconds and returns non-zero exit status. Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR fixes the liveness probe on cstor-pool container by adding
timeoutsetting for command execution(run a command with a time limit).timeoutwill be helpful in a case when the disks are detached from the node and when liveness triggers command(zfs set... command) it will be hung forever and kubelet will not treat them as a failures. Kubelet also retries execute the same command aftertimeoutSecondsmentioned in the liveness probe. By triggeringtimeout 120 zfs set io.openebs:livenesstimestamp="$(date +%s)" cstor-<pool_name>will kill the process if it exceeds more than 120 seconds and returns non-zero exit status.Note:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #openebs/openebs#2852Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag