feat(helm): Helm chart changes for issue #113 and PR #114 #116
Conversation
…ve#114 Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <[email protected]>
mynktl
added
the
release-activity
There was a problem hiding this comment.
Thanks for the PR!!
Can we also update the nfs-operator yaml with OPENEBS_IO_NFS_SERVER_IMAGE_PULL_SECRET env like added here as commented value? This will help for user using nfs-operator.yaml without looking around at docs
| @@ -112,6 +112,7 @@ nfsStorageClass: | |||
|
|
|||
| nfsServer: | |||
| useClusterIP: "true" | |||
| imagePullSecret: "" | |||
There was a problem hiding this comment.
Can we update the configuration in README.md and bump the chart version? Example of updating README.md and chart version
|
Whoops, I was trying to rebase but did it wrong and deleted my branch, which I forgot would close this pull request. :( Sorry about that. I'll open a new one. @mittachaitu |
@mittachaitu the new one is now #117. |
Adds support for setting an image pull secret on the
NFS Server pods.
Signed-off-by: Grant Linville [email protected]
Pull Request template
Why is this PR required? What issue does it fix?:
This makes the needed Helm chart changes for issue #113 and PR #114.
What this PR does?:
This adds an environment variable to the Deployment that can be configured from the values file. The variable is a string that can be set to the name of an image pull secret to be used by NFS Server pods.
Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
I used the
helm templatecommand to render out the chart, first leaving thenfsServer.imagePullSecretvalue unset and seeing that the environment variable was not rendered, and then setting the value and seeing that the environment variable was rendered.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
This PR is a continuation of #114.
Checklist:
<type>(<scope>): <subject>