Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): add support for ImagePullSecret in NFS Server Pods #114

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

g-linville
Copy link
Contributor

@g-linville g-linville commented Sep 20, 2021

This commit modifies the Helm chart as well as the
provisioner itself to allow an ImagePullSecret for
the NFS Server Pods to be passed in through an
environment variable.

Signed-off-by: Grant Linville [email protected]

Pull Request template

Why is this PR required? What issue does it fix?:
This fixes issue #113.

What this PR does?:
It add support to use an image pull secret in the NFS Server, allowing users to pull an image for it from a private container registry.

Does this PR require any upgrade changes?:
Not to my knowledge. If there is no image pull secret specified as an environment variable, the default of an empty string is used, which is ignored later on when the NFS Server Deployment is created.

If the changes in this PR are manually verified, list down the scenarios covered::
I added a test for the change that I made to the podtemplatespec and that (along with all the other tests) passed, but I have done no verification beyond that.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Nope!

Checklist:

This commit modifies the Helm chart as well as the
provisioner itself to allow an ImagePullSecret for
the NFS Server Pods to be passed in through an
environment variable.

Signed-off-by: Grant Linville <[email protected]>
Copy link
Contributor

@mynktl mynktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g-linville
Thanks for the PR. There is one small change required to move helm changes to separate PR. Rest Changes look good.

deploy/helm/charts/templates/deployment.yaml Outdated Show resolved Hide resolved
@mynktl mynktl added the enhancement New feature or request label Sep 21, 2021
g-linville added a commit to g-linville/dynamic-nfs-provisioner that referenced this pull request Sep 21, 2021
…ve#114

Adds support for setting an image pull secret on the
NFS Server pods.

Signed-off-by: Grant Linville <[email protected]>
@g-linville
Copy link
Contributor Author

@mynktl Thank you very much for the fast review! My Helm chart changes are now in PR #116.

Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@codecov-commenter
Copy link

Codecov Report

Merging #114 (e97f567) into develop (ebd70a3) will increase coverage by 0.14%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
+ Coverage    46.97%   47.11%   +0.14%     
===========================================
  Files           29       29              
  Lines         2378     2390      +12     
===========================================
+ Hits          1117     1126       +9     
- Misses        1182     1185       +3     
  Partials        79       79              
Impacted Files Coverage Δ
provisioner/controller.go 0.00% <0.00%> (ø)
...tes/api/core/v1/podtemplatespec/podtemplatespec.go 38.55% <100.00%> (+1.32%) ⬆️
provisioner/env.go 33.33% <100.00%> (+8.33%) ⬆️
provisioner/helper_kernel_nfs_server.go 79.71% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b390f9...e97f567. Read the comment docs.

@mynktl mynktl merged commit a8612f3 into openebs-archive:develop Sep 22, 2021
@g-linville g-linville deleted the 113-image-pull-secret branch September 22, 2021 14:15
g-linville added a commit to g-linville/dynamic-nfs-provisioner that referenced this pull request Sep 22, 2021
…ve#114

Adds support for setting an image pull secret on the
NFS Server pods.

Signed-off-by: Grant Linville <[email protected]>
mynktl pushed a commit that referenced this pull request Nov 11, 2021
Adds support for setting an image pull secret on the
NFS Server pods.

Signed-off-by: Grant Linville <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for an image pull secret in the NFS Server pods
4 participants