-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): add support for ImagePullSecret in NFS Server Pods #114
feat(k8s): add support for ImagePullSecret in NFS Server Pods #114
Conversation
This commit modifies the Helm chart as well as the provisioner itself to allow an ImagePullSecret for the NFS Server Pods to be passed in through an environment variable. Signed-off-by: Grant Linville <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@g-linville
Thanks for the PR. There is one small change required to move helm changes to separate PR. Rest Changes look good.
Signed-off-by: Grant Linville <[email protected]>
…ve#114 Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
Codecov Report
@@ Coverage Diff @@
## develop #114 +/- ##
===========================================
+ Coverage 46.97% 47.11% +0.14%
===========================================
Files 29 29
Lines 2378 2390 +12
===========================================
+ Hits 1117 1126 +9
- Misses 1182 1185 +3
Partials 79 79
Continue to review full report at Codecov.
|
…ve#114 Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <[email protected]>
Adds support for setting an image pull secret on the NFS Server pods. Signed-off-by: Grant Linville <[email protected]>
This commit modifies the Helm chart as well as the
provisioner itself to allow an ImagePullSecret for
the NFS Server Pods to be passed in through an
environment variable.
Signed-off-by: Grant Linville [email protected]
Pull Request template
Why is this PR required? What issue does it fix?:
This fixes issue #113.
What this PR does?:
It add support to use an image pull secret in the NFS Server, allowing users to pull an image for it from a private container registry.
Does this PR require any upgrade changes?:
Not to my knowledge. If there is no image pull secret specified as an environment variable, the default of an empty string is used, which is ignored later on when the NFS Server Deployment is created.
If the changes in this PR are manually verified, list down the scenarios covered::
I added a test for the change that I made to the podtemplatespec and that (along with all the other tests) passed, but I have done no verification beyond that.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Nope!
Checklist:
<type>(<scope>): <subject>