-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(cvc):remove configclass reference from CVC and add validations #25
Merged
vishnuitta
merged 6 commits into
openebs-archive:master
from
prateekpandey14:rm-configclass
Jul 18, 2019
Merged
refact(cvc):remove configclass reference from CVC and add validations #25
vishnuitta
merged 6 commits into
openebs-archive:master
from
prateekpandey14:rm-configclass
Jul 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnuitta
reviewed
Jul 18, 2019
vishnuitta
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
payes
approved these changes
Jul 18, 2019
- Add replicaCount and StoragePoolClaim parameter validations Signed-off-by: prateekpandey14 <[email protected]>
Commit pull the latest openebs-operator file to deploy openebs components for integration tests. Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
vishnuitta
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components for integration tests
Signed-off-by: prateekpandey14 [email protected]