Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(cvc):remove configclass reference from CVC and add validations #25

Merged
merged 6 commits into from
Jul 18, 2019
Merged

refact(cvc):remove configclass reference from CVC and add validations #25

merged 6 commits into from
Jul 18, 2019

Conversation

prateekpandey14
Copy link
Contributor

@prateekpandey14 prateekpandey14 commented Jul 17, 2019 •
edited
Loading

  • Remove configClass reference from CVC
  • Add replicaCount and StoragePoolClaim parameter validations.
  • Pull the latest openebs-operator file to deploy openebs
    components for integration tests

Signed-off-by: prateekpandey14 [email protected]

@vishnuitta vishnuitta requested a review from payes July 18, 2019 06:18
vishnuitta
vishnuitta approved these changes Jul 18, 2019
View reviewed changes
Copy link

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@payes
Copy link
Contributor

payes commented Jul 18, 2019

#25 and #23 are interrelated.
Both these need to be merged at the same time for travis to pass.

@prateekpandey14
refact(cvc):remove configclass reference from CVC and add validations
5fbc13d 
- Add replicaCount and StoragePoolClaim parameter validations

Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
fix(operator, bdd): use latest openebs-operator from openebs master
69f1e27 
Commit pull the latest openebs-operator file to deploy openebs
components for integration tests.

Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
dump csi controller and node logs
c6f0c41 
Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
Update to print logs
0661706 
Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
Install iscsi on node in travis
cc843a9 
Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
fix(travis, bdd): update makefile with quay tag image
23c318d 
Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14 prateekpandey14 mentioned this pull request Jul 18, 2019
Merged
vishnuitta
vishnuitta approved these changes Jul 18, 2019
View reviewed changes
Copy link

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit 5ba71fd into openebs-archive:master Jul 18, 2019
@kmova kmova added this to the 1.1.0 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@payes payes payes approved these changes

@vishnuitta vishnuitta vishnuitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prateekpandey14 @payes @vishnuitta @kmova