-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(golang-ci): update folder structure and fix golang-ci lint error #24
fix(golang-ci): update folder structure and fix golang-ci lint error #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage ? 53.72%
=========================================
Files ? 12
Lines ? 631
Branches ? 0
=========================================
Hits ? 339
Misses ? 272
Partials ? 20
Continue to review full report at Codecov.
|
- Move pkg/generated/maya dir to pkg/maya follows standard pkg dir structure - fix the client versioned issue which causing golang-ci lint to fail in first place - fix unit test Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
Needs rebase once PR #25 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
…24) - Move pkg/generated/maya dir to pkg/maya follows standard pkg dir structure - fix the client versioned issue which causing golang-ci lint to fail in first place - fix unit test Signed-off-by: prateekpandey14 <[email protected]>
to fail in first place
Signed-off-by: prateekpandey14 [email protected]