Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(golang-ci): update folder structure and fix golang-ci lint error #24

Merged
merged 2 commits into from
Jul 18, 2019
Merged

fix(golang-ci): update folder structure and fix golang-ci lint error #24

merged 2 commits into from
Jul 18, 2019

Conversation

prateekpandey14
Copy link
Contributor

@prateekpandey14 prateekpandey14 commented Jul 17, 2019 •
edited
Loading

  • Move pkg/generated/maya dir to pkg/maya follows standard pkg dir structure
  • fix the client versioned issue which causing golang-ci lint
    to fail in first place

Signed-off-by: prateekpandey14 [email protected]

@codecov-io
Copy link

codecov-io commented Jul 17, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dad77dd). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage          ?   53.72%           
=========================================
  Files             ?       12           
  Lines             ?      631           
  Branches          ?        0           
=========================================
  Hits              ?      339           
  Misses            ?      272           
  Partials          ?       20
Impacted Files Coverage Δ
...etes/persistentvolume/v1alpha1/persistentvolume.go 17.85% <ø> (ø)
.../kubernetes/persistentvolume/v1alpha1/buildlist.go 50% <ø> (ø)
pkg/maya/kubernetes/client/v1alpha1/client.go 89.55% <ø> (ø)
pkg/maya/kubernetes/node/v1alpha1/kubernetes.go 43.47% <ø> (ø)
pkg/maya/errors/v1alpha1/types.go 0% <ø> (ø)
pkg/maya/errors/v1alpha1/errors.go 0% <ø> (ø)
pkg/maya/env/v1alpha1/env.go 58.62% <ø> (ø)
...maya/kubernetes/persistentvolume/v1alpha1/build.go 92.4% <ø> (ø)
pkg/maya/cstorvolume/v1alpha1/cstorvolume.go 34.28% <ø> (ø)
pkg/maya/kubernetes/node/v1alpha1/node.go 82.97% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad77dd...4c1b809. Read the comment docs.

@prateekpandey14
fix(golang-ci): update folder structure and fix golang-ci lint error
a286da5 
- Move pkg/generated/maya dir to pkg/maya follows standard pkg dir structure
- fix the client versioned issue which causing golang-ci lint
  to fail in first place
- fix unit test

Signed-off-by: prateekpandey14 <[email protected]>
@vishnuitta vishnuitta requested a review from payes July 17, 2019 15:10
@prateekpandey14
fix review comments
4c1b809 
Signed-off-by: prateekpandey14 <[email protected]>
@prateekpandey14
Copy link
Contributor Author

Needs rebase once PR #25 merged

payes
payes approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@payes payes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vishnuitta
vishnuitta approved these changes Jul 18, 2019
View reviewed changes
Copy link

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit 970295a into openebs-archive:master Jul 18, 2019
vishnuitta pushed a commit that referenced this pull request Jul 28, 2019
@prateekpandey14 @vishnuitta
fix(golang-ci): update folder structure and fix golang-ci lint error (#…
ac5280e 
…24)

- Move pkg/generated/maya dir to pkg/maya follows standard pkg dir structure
- fix the client versioned issue which causing golang-ci lint
  to fail in first place
- fix unit test

Signed-off-by: prateekpandey14 <[email protected]>
@kmova kmova added this to the 1.1.0 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitKumarDas AmitKumarDas AmitKumarDas left review comments

@golangcibot golangcibot golangcibot left review comments

@payes payes payes approved these changes

@vishnuitta vishnuitta vishnuitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@prateekpandey14 @codecov-io @AmitKumarDas @payes @vishnuitta @golangcibot @kmova