Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): update error log message during NodeStage request #157

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix(log): update error log message during NodeStage request #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/driver/node_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,15 +359,15 @@ func (ns *node) prepareVolumeForNode(
oldNodeName := csiVol.GetLabels()["nodeID"]

if oldNodeName == nodeID {
return errors.Errorf("Volume %s still mounted on node: %s", volumeID, nodeID)
return errors.Errorf("Volume %s still mounted on node: %s", volumeID, oldNodeName)
}

isNodeReady, err := k8snode.IsNodeReady(oldNodeName)
if err != nil && !k8serror.IsNotFound(err) {
logrus.Errorf("failed to get the node %s details error: %s", oldNodeName, err.Error())
return errors.Wrapf(err, "failed to get node %s details to know previous mounts", oldNodeName)
} else if err == nil && isNodeReady {
return errors.Errorf("Volume %s still mounted on node %s", volumeID, nodeID)
return errors.Errorf("Volume %s still mounted on node %s", volumeID, oldNodeName)
}
}

Expand Down