Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): update error log message during NodeStage request #157

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

mittachaitu
Copy link

What this PR does:
This PR updates the error message during NodeStage request time
to show the node name where the volume is already mounted.

Existing Pod:

$ kubectl get po -A -o wide
NAMESPACE     NAME                                                              READY   STATUS              RESTARTS   AGE     IP             NODE              NOMINATED NODE   READINESS GATES
default       percona-69fb95ccb4-qvm6p                                          1/1     Running             0          31m     10.244.1.112   centos-worker-1   <none>           <none>
default       percona-86b789d974-5xgkk                                          0/1     ContainerCreating   0          5s      <none>         centos-master     <none>           <none>

Describe of pod in container creating state:

Events:
  Type     Reason       Age               From               Message
  ----     ------       ----              ----               -------
  Normal   Scheduled    13s               default-scheduler  Successfully assigned default/percona-86b789d974-5xgkk to centos-master
  Warning  FailedMount  5s (x5 over 13s)  kubelet            MountVolume.MountDevice failed for volume "pvc-902f9b08-b5d2-4f22-81c3-d580f5087642" : rpc error: code = Internal desc = Volume pvc-902f9b08-b5d2-4f22-81c3-d580f5087642 still mounted on node centos-worker-1

Which issue(s) this PR fixes:
Fixes #
NA

Special notes for your reviewer:

Checklist

  • PR messages has document related information
  • Labelled this PR & related issue with documentation tag
  • PR messages has breaking changes related information
  • PR messages has upgrade related information
  • Labelled this PR & related issue with requires-upgrade tag
  • Tests updated

Signed-off-by: mittachaitu [email protected]

This commit updates the error message to show the node name
where the volume is already mounted

Signed-off-by: mittachaitu <[email protected]>
@prateekpandey14 prateekpandey14 merged commit 706bd32 into openebs-archive:master Jul 21, 2021
mittachaitu pushed a commit to mittachaitu/cstor-csi that referenced this pull request Jul 22, 2021
…archive#157)

This commit updates the error message to show the node name
where the volume is already mounted

Signed-off-by: mittachaitu <[email protected]>
prateekpandey14 pushed a commit that referenced this pull request Jul 22, 2021
)

This commit updates the error message to show the node name
where the volume is already mounted

Signed-off-by: mittachaitu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants