-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create): validate create volume request access mode #109
fix(create): validate create volume request access mode #109
Conversation
4fa7f29
to
90b6a76
Compare
Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
90b6a76
to
1ac5218
Compare
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 7 7
Lines 335 335
=======================================
Hits 214 214
Misses 108 108
Partials 13 13 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provided comments related to the error message. Rest of changes are good
Signed-off-by: prateekpandey14 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good
…ive#109) Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
…ive#109) Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
…ive#109) Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
…ive#109) Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 [email protected]
What this PR does:
Commits adds the validation to validate the create volume request access mode and support only single node writer
i.e.
ReadWriteOnce
accessmode and failed for other unsupported modes, likeReadWriteMany
ReadWriteMany
accessmode PVC and verify the error.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
documentation
tagrequires-upgrade
tag