fix(create): validate create volume request access mode (openebs-arch…

…ive#109) Commits adds the validation to validate the create volume request access mode to validate and support only single node writer i.e. `ReadWriteOnce` accessmode and failed for other unsupported modes, like `ReadWriteMany` Signed-off-by: prateekpandey14 <[email protected]>
mittachaitu · Aug 13, 2020 · e1b5c53 · e1b5c53
1 parent 5240df1
commit e1b5c53
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/ci/ci-test.sh b/ci/ci-test.sh
@@ -31,9 +31,7 @@ DST_PATH="$GOPATH/src/github.com/openebs"
 # Minikube is already running
 kubectl apply -f $CSTOR_RBAC
 kubectl apply -f $NDM_OPERATOR
-kubectl apply -f $VOL_CRD
-kubectl apply -f $CSPC_CRD
-kubectl apply -f $CSPI_CRD
+kubectl apply -f $ALL_CRD
 kubectl apply -f $CSTOR_OPERATOR
 kubectl apply -f $CSI_OPERATOR
 kubectl apply -f $SNAPSHOT_CLASS

diff --git a/pkg/driver/controller_utils.go b/pkg/driver/controller_utils.go
@@ -150,6 +150,16 @@ func (cs *controller) validateVolumeCreateReq(req *csi.CreateVolumeRequest) erro
 				)
 			}
 		}
+		if mode := volcap.GetAccessMode(); mode != nil {
+			modeName := csi.VolumeCapability_AccessMode_Mode_name[int32(mode.GetMode())]
+			// we only support SINGLE_NODE_WRITER
+			if mode.GetMode() != csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER {
+				return status.Errorf(codes.InvalidArgument,
+					"only SINGLE_NODE_WRITER supported, unsupported access mode requested: %s",
+					modeName,
+				)
+			}
+		}
 	}
 	return nil
 }