Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package creator and sources #390

Merged
merged 8 commits into from
Jan 5, 2023
Merged

Fix package creator and sources #390

merged 8 commits into from
Jan 5, 2023

Conversation

ad-daniel
Copy link
Collaborator

@ad-daniel ad-daniel commented Dec 30, 2022

The creation was successful, however the root package wasn't uploaded due to a missing new line in packages.txt.
I've uploaded the missing one manually, this is just to ensure everything is fine

@ad-daniel ad-daniel added test sources Run style checks test release Tests if a wheel created from a branch runs correctly labels Dec 30, 2022
@ad-daniel ad-daniel self-assigned this Dec 30, 2022
@ad-daniel
Copy link
Collaborator Author

ad-daniel commented Dec 30, 2022

mmh, actually running the test release wouldn't really test it. In the relevant part of the workflow we install ALL the packages (1 by 1) and then test that all unittests still pass. We probably did it this way to ensure it used the locally generated packages rather than install the root and download its dependencies from pypi). I see benefits in both approaches, but perhaps we should still manually ensure that by installing it from the root package everything still works

Edit: although the current approach makes sense as users might install multiple tools separately, it's just as likely for them to install the full one (if they need more than a handful), so perhaps we should change the test accordingly

@ad-daniel ad-daniel added test packages Test pip wheel and docker image and removed test release Tests if a wheel created from a branch runs correctly test packages Test pip wheel and docker image labels Jan 3, 2023
@ad-daniel ad-daniel added test release Tests if a wheel created from a branch runs correctly and removed test packages Test pip wheel and docker image labels Jan 3, 2023
@ad-daniel ad-daniel changed the title Fix package creator Fix package creator and sources Jan 4, 2023
@ad-daniel
Copy link
Collaborator Author

It seems that the following two installation methods:

  • install engine + opendr-toolkit (full install)
  • install engine + each pip package separately

although identical in theory, they do not yield the same result dependency wise and the first approach has dependency issues whereas the second doesn't. This PR only addresses:

  • fix copyright (& test sources)
  • version bump
  • fix package publisher not creating a package for the entire toolkit (missing new line)

@ad-daniel ad-daniel marked this pull request as ready for review January 4, 2023 07:54
@tsampazk tsampazk mentioned this pull request Jan 4, 2023
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Daniel!

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ad-daniel ad-daniel merged commit 6999127 into master Jan 5, 2023
@ad-daniel ad-daniel deleted the fix-publisher branch January 5, 2023 08:25
Pavlos-Tosidis added a commit that referenced this pull request Jan 26, 2023
* Fix branch references

* Version fixes

* Fix version

* Add changelog entry

* Fix package creator and sources (#390)

* Fix package creator

* update copyright

* Version bump

* Fix test packages

* Remove fail-fast

* Debug

* Fix

* Restore

* Add zenodo DOI badge (#396)

Co-authored-by: ad-daniel <[email protected]>
Co-authored-by: ad-daniel <[email protected]>
Co-authored-by: Nikolaos Passalis <[email protected]>
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* Fix package creator

* update copyright

* Version bump

* Fix test packages

* Remove fail-fast

* Debug

* Fix

* Restore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test release Tests if a wheel created from a branch runs correctly test sources Run style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants