-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package creator and sources #390
Conversation
mmh, actually running the Edit: although the current approach makes sense as users might install multiple tools separately, it's just as likely for them to install the full one (if they need more than a handful), so perhaps we should change the test accordingly |
It seems that the following two installation methods:
although identical in theory, they do not yield the same result dependency wise and the first approach has dependency issues whereas the second doesn't. This PR only addresses:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Daniel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Fix branch references * Version fixes * Fix version * Add changelog entry * Fix package creator and sources (#390) * Fix package creator * update copyright * Version bump * Fix test packages * Remove fail-fast * Debug * Fix * Restore * Add zenodo DOI badge (#396) Co-authored-by: ad-daniel <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Nikolaos Passalis <[email protected]>
* Fix package creator * update copyright * Version bump * Fix test packages * Remove fail-fast * Debug * Fix * Restore
The creation was successful, however the root package wasn't uploaded due to a missing new line in
packages.txt
.I've uploaded the missing one manually, this is just to ensure everything is fine