Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bbox/tracking 2D/3D list confidence #365

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Fix bbox/tracking 2D/3D list confidence #365

merged 7 commits into from
Dec 8, 2022

Conversation

iliiliiliili
Copy link
Collaborator

@iliiliiliili iliiliiliili added test sources Run style checks test tools Test the toolkit methods labels Nov 30, 2022
@tsampazk tsampazk linked an issue Nov 30, 2022 that may be closed by this pull request
BoundingBoxList(Target) ctor throws RuntimeWarning when provided with empty list #362
Closed
@tsampazk tsampazk self-requested a review November 30, 2022 18:38
tsampazk
tsampazk reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Illia for the fixes, changes look good, i have just one comment.

src/opendr/engine/target.py Outdated Show resolved Hide resolved
@iliiliiliili
Copy link
Collaborator Author

Some strange errors occur across different tests with no module found, such as:
ModuleNotFoundError: No module named 'cv2'

@tsampazk
Copy link
Collaborator

tsampazk commented Dec 2, 2022

Some strange errors occur across different tests with no module found, such as: ModuleNotFoundError: No module named 'cv2'

There seems to be some wider issue at play here, i don't think the errors in the tests are related to the changes in this PR.

@ad-daniel
Copy link
Collaborator

I've re-run the PR and the problems seem to have gone. Likely a CI hiccup

tsampazk
tsampazk previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ad-daniel
ad-daniel approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

passalis
passalis approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ad-daniel ad-daniel merged commit d51b145 into develop Dec 8, 2022
@ad-daniel ad-daniel deleted the fix-bounding-box-confidence branch December 8, 2022 11:27
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@iliiliiliili @ad-daniel
Fix bbox/tracking 2D/3D list confidence (opendr-eu#365)
5cdcd20 
* Fix bbox segmentation unbound

* Add bbox list image id

* Fix bbox and annotation list confidence computation

* Make immutable defaults for list targets

* Add changelog entry

Co-authored-by: ad-daniel <[email protected]>
Co-authored-by: ad-daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-daniel ad-daniel ad-daniel approved these changes

@passalis passalis passalis approved these changes

@tsampazk tsampazk tsampazk left review comments

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@stefaniapedrazzi stefaniapedrazzi Awaiting requested review from stefaniapedrazzi stefaniapedrazzi is a code owner

Assignees
No one assigned
Labels
test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BoundingBoxList(Target) ctor throws RuntimeWarning when provided with empty list
4 participants
@iliiliiliili @tsampazk @ad-daniel @passalis