Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Added datetime data type and basic functions for the conversion from string type to date and time types #694

Merged
merged 16 commits into from
Aug 26, 2020

Conversation

chloe-zh
Copy link
Member

Issue #, if available:

Description of changes:

  • Added datetime type
  • Modified the properties and methods in expression values of date, time, timestamp types
  • Added function date, datetime, time, timestamp as the conversion method to convert string to date and time types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Conflicts:
#	core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValue.java
#	core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValueUtils.java
#	core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/type/ExprCoreType.java
#	core/src/test/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValueUtilsTest.java
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@chloe-zh chloe-zh merged commit 8c8ad61 into opendistro-for-elasticsearch:develop Aug 26, 2020
@chloe-zh
Copy link
Member Author

#709

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants