This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Added datetime data type and basic functions for the conversion from string type to date and time types #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValue.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValueUtils.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/type/ExprCoreType.java # core/src/test/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValueUtilsTest.java
penghuo
reviewed
Aug 25, 2020
...ain/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Aug 25, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprValueUtils.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Aug 25, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/data/model/ExprDatetimeValue.java
Show resolved
Hide resolved
penghuo
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
dai-chen
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
date
,datetime
,time
,timestamp
as the conversion method to convert string to date and time typesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.