This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add temporal interval data type and support interval clause as function #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Aug 18, 2020
penghuo
reviewed
Aug 18, 2020
| @@ -172,4 +171,8 @@ public static Boolean getBooleanValue(ExprValue exprValue) { | |||
| public static ZonedDateTime getDateValue(ExprValue exprValue) { | |||
| return exprValue.dateValue(); | |||
| } | |||
|
|
|||
| public static TemporalAmount getIntervalValue(ExprValue exprValue) { | |||
There was a problem hiding this comment.
yes, i've also added getTimeValue, getDatetimeValue, getTimestampValue in the other PR #694 to stay consistent. We can also remove all these methods including the getDateValue actually
penghuo
reviewed
Aug 18, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/ast/expression/DataType.java
Show resolved
Hide resolved
penghuo
reviewed
Aug 18, 2020
...src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/function/FunctionDSL.java
Show resolved
Hide resolved
penghuo
reviewed
Aug 18, 2020
.../main/java/com/amazon/opendistroforelasticsearch/sql/expression/datetime/IntervalClause.java
Outdated
Show resolved
Hide resolved
|
So in this PR the changes regarding parser only covers PPL language? |
Added parser in SQL in the latest update, thanks! |
Thanks for adding! In this case please add comparison test case to make sure it can work with JDBC driver together. |
# Conflicts: # sql/src/main/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/AstExpressionBuilder.java # sql/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/AstExpressionBuilderTest.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Doc: https://github.com/chloe-zh/sql/blob/interval/docs/user/general/datatypes.rst
Added
INTERVALdata type in the SQL language structure. Syntax:INTERVAL expr unit. The corresponding expression value isExprIntervalValuethat can encapsulate the temporal amount as the property value.Quantity expression
exprin interval clause can be any value expression, including the basic numeric values, field expression, functions etc. which has been revealed in the parser.Interval units to support for phase 1: microsecond, second, minute, hour, day, week, month, quarter, year.
Added docs for date and time data types.
[TODO] Current PR does not contain examples of date and time types in the reference manual yet. These examples will be added in the coming PR for datetime functions where functions
date,time,datetime,timestampandintervalare implemented.Note:
Interval data type maps to
TemporalAmountin Java runtime, it has two types of amountDurationsubclass that can be mapped with microseconds to days, where all amount would be converted to a value withsecondas the unit; and another amountPeriodcan be mapped with days to years, where the values would be converted to some value withdayas the the unit. This rule is similar to H2: https://www.h2database.com/html/datatypes.html#interval_typeIn this PR, these two types are sharing the same syntax, but will differ in the storage method, and is only comparable with the same type of interval. For example, the comparison between
INTERVAL 1 weekwithINTERVAL 1 monthwill result in 1 week is shorter than 1 month, but an attempt to compareINTERVAL 1 weekwithINTERVAL 1 minutewill fail and throw an exception. Which is also similar to H2 behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.