Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix failure in IT test with external cluster #393

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

zhongnansu
Copy link
Member

Issue #, if available:
#391 causes github workflow failure
Description of changes:

  1. Fix failure in IT test with external cluster, basically the previous PR fix Jacoco integration issue by updating internal testing infrastructure #391 which caused a github workflow failure
  2. Add try with resource to avoid JMX connector won't close when an exception is thrown.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhongnansu zhongnansu requested review from chloe-zh and dai-chen March 24, 2020 18:57
Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks for the fix!

@zhongnansu zhongnansu merged commit 941065b into opendistro-for-elasticsearch:master Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants