This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix Jacoco integration issue by updating internal testing infrastructure #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
davidcui1225,
dai-chen,
abbashus,
chloe-zh and
penghuo
davidcui1225
approved these changes
Mar 23, 2020
| return; | ||
| } | ||
|
|
||
| String serverUrl = "service:jmx:rmi:///jndi/rmi://127.0.0.1:7777/jmxrmi"; |
There was a problem hiding this comment.
np: extra whitespace here
chloe-zh
approved these changes
Mar 23, 2020
|
NPE is thrown in integration test with external ES cluster |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#376
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.