This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 31, 2020
vigyasharma
added
code-refactoring
The change reduces the cognitive load of the reader of the code and makes adding new changes easier
enhancement
Enhancements to existing codebase
labels
Aug 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
============================================
+ Coverage 70.09% 70.58% +0.48%
- Complexity 2287 2311 +24
============================================
Files 303 307 +4
Lines 13605 13686 +81
Branches 1133 1142 +9
============================================
+ Hits 9537 9660 +123
+ Misses 3695 3663 -32
+ Partials 373 363 -10 Continue to review full report at Codecov.
|
This was referenced Aug 31, 2020
Merged
rguo-aws
reviewed
Aug 31, 2020
...distro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyCacheMaxSizeAction.java
Show resolved
Hide resolved
...istro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyQueueCapacityAction.java
Show resolved
Hide resolved
...com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/NestedConfig.java
Show resolved
Hide resolved
...istro/elasticsearch/performanceanalyzer/decisionmaker/actions/configs/CacheActionConfig.java
Outdated
Show resolved
Hide resolved
...istro/elasticsearch/performanceanalyzer/decisionmaker/actions/configs/QueueActionConfig.java
Outdated
Show resolved
Hide resolved
ktkrg
previously approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
rguo-aws
previously approved these changes
Aug 31, 2020
- Add nullable annotations - Move default values to static final variables
vigyasharma
force-pushed
the
action-configs
branch
from
September 1, 2020 16:31
e747fbe
to
f8ddb98
Compare
rguo-aws
approved these changes
Sep 1, 2020
ktkrg
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
code-refactoring
The change reduces the cognitive load of the reader of the code and makes adding new changes easier
enhancement
Enhancements to existing codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #403 #404 #405
Description: This change allows action level configurations to be provided via config file -
rca.conf
.Additional code refactoring includes:
Config
objects to encapsulate the an entire configuration. These allow config key, value, default value and validation functions to be stored in a single object.NestedConfig
to recursively nest through a map and support multi-level nested configurations. Current support only allowed for three nested levels.DeciderConfig
rca.conf
RcaConf
to allow passing config jsons as strings for tests.TimeExpiringSetTest.testExpiringIteration
Tests: Added unit tests for all components
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.