Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add collector time period to rca.conf #401

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Conversation

sruti1312
Copy link
Contributor

Fixes #:

Description of changes:
Add cache collector time period thresholds to rca.conf

Tests:
unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sruti1312 sruti1312 requested review from khushbr and rguo-aws August 28, 2020 22:31
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #401 into master will increase coverage by 0.12%.
The diff coverage is 74.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
+ Coverage     69.52%   69.65%   +0.12%     
- Complexity     2370     2392      +22     
============================================
  Files           318      319       +1     
  Lines         14273    14290      +17     
  Branches       1199     1186      -13     
============================================
+ Hits           9924     9953      +29     
+ Misses         3982     3968      -14     
- Partials        367      369       +2     
Impacted Files Coverage Δ Complexity Δ
...yzer/rca/configs/HighHeapUsageOldGenRcaConfig.java 66.66% <0.00%> (+4.16%) 4.00 <1.00> (+1.00)
...eanalyzer/rca/configs/HotNodeClusterRcaConfig.java 70.00% <0.00%> (+11.66%) 6.00 <2.00> (+2.00)
...analyzer/rca/configs/HotShardClusterRcaConfig.java 66.66% <0.00%> (+13.33%) 7.00 <3.00> (+3.00)
...ormanceanalyzer/rca/configs/HotShardRcaConfig.java 66.66% <0.00%> (+13.33%) 7.00 <3.00> (+3.00)
...eanalyzer/rca/configs/QueueRejectionRcaConfig.java 66.66% <0.00%> (-19.05%) 3.00 <1.00> (ø)
...er/rca/configs/HighHeapUsageYoungGenRcaConfig.java 72.72% <60.00%> (+14.39%) 6.00 <2.00> (+2.00)
...eanalyzer/rca/configs/FieldDataCacheRcaConfig.java 76.92% <76.92%> (ø) 5.00 <5.00> (?)
...alyzer/rca/configs/ShardRequestCacheRcaConfig.java 76.92% <76.92%> (ø) 5.00 <5.00> (?)
...erformanceanalyzer/rca/framework/core/RcaConf.java 54.20% <81.81%> (+2.24%) 35.00 <8.00> (+3.00)
...nalyzer/rca/store/rca/cache/FieldDataCacheRca.java 94.28% <100.00%> (+0.34%) 11.00 <1.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1decacb...2521ff9. Read the comment docs.

Copy link
Contributor

@vigyasharma vigyasharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sruti1312 . Holding back approval mainly for the default value handling changes. Will leave handling other comments to your discretion.

Copy link
Contributor

@rguo-aws rguo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sruti1312 sruti1312 merged commit 97e0189 into master Sep 8, 2020
@sruti1312 sruti1312 deleted the partsrut-collector-config branch September 8, 2020 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants