This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
============================================
+ Coverage 69.52% 69.65% +0.12%
- Complexity 2370 2392 +22
============================================
Files 318 319 +1
Lines 14273 14290 +17
Branches 1199 1186 -13
============================================
+ Hits 9924 9953 +29
+ Misses 3982 3968 -14
- Partials 367 369 +2 Continue to review full report at Codecov.
|
rguo-aws
suggested changes
Aug 28, 2020
...in/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/configs/CacheConfig.java
Outdated
Show resolved
Hide resolved
vigyasharma
previously approved these changes
Aug 31, 2020
...distro/elasticsearch/performanceanalyzer/rca/integTests/tests/cache_tuning/resource/rca.conf
Outdated
Show resolved
Hide resolved
...in/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/configs/CacheConfig.java
Outdated
Show resolved
Hide resolved
vigyasharma
suggested changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sruti1312 . Holding back approval mainly for the default value handling changes. Will leave handling other comments to your discretion.
...java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
Show resolved
Hide resolved
...java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
Outdated
Show resolved
Hide resolved
...distro/elasticsearch/performanceanalyzer/rca/integTests/tests/cache_tuning/resource/rca.conf
Outdated
Show resolved
Hide resolved
...distro/elasticsearch/performanceanalyzer/rca/integTests/tests/cache_tuning/resource/rca.conf
Show resolved
Hide resolved
...zon/opendistro/elasticsearch/performanceanalyzer/rca/configs/ShardRequestCacheRcaConfig.java
Outdated
Show resolved
Hide resolved
vigyasharma
previously approved these changes
Sep 3, 2020
...java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
Show resolved
Hide resolved
rguo-aws
reviewed
Sep 3, 2020
...java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
Show resolved
Hide resolved
rguo-aws
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vigyasharma
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
Description of changes:
Add cache collector time period thresholds to rca.conf
Tests:
unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.