This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add listeners for publisher actions #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rguo-aws
reviewed
Jul 21, 2020
| @@ -30,10 +33,12 @@ | |||
|
|
|||
| private Collator collator; | |||
| private boolean isMuted = false; | |||
| private List<ActionListener> actionListeners; | |||
There was a problem hiding this comment.
should we make this list thread safe ? it looks to me that addActionListener() is called from a different thread.
There was a problem hiding this comment.
It should only be called during instantiation of the graph, not during regular scheduling.
rguo-aws
reviewed
Jul 21, 2020
...n/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/plugins/PluginController.java
Outdated
Show resolved
Hide resolved
rguo-aws
reviewed
Jul 21, 2020
...n/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/plugins/PluginController.java
Show resolved
Hide resolved
sidheart
approved these changes
Jul 21, 2020
vigyasharma
force-pushed
the
vs-ac-listener
branch
from
2c1e740 to
a0a3d3a
Compare
vigyasharma
requested review from
rguo-aws and
sidheart
and removed request for
yojs
rguo-aws
approved these changes
Jul 27, 2020
vigyasharma
force-pushed
the
vs-ac-listener
branch
from
c3d4169 to
5366e63
Compare
sidheart
reviewed
Jul 27, 2020
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class PluginControllerConfig { |
There was a problem hiding this comment.
Can we use a singleton pattern here instead of static? Then we can avoid the PowerMock stuff in the test class and have multiple configs in one JVM context
sidheart
reviewed
Jul 27, 2020
...va/com/amazon/opendistro/elasticsearch/performanceanalyzer/plugins/PluginControllerTest.java
Outdated
Show resolved
Hide resolved
vigyasharma
force-pushed
the
vs-ac-listener
branch
2 times, most recently
from
0da4e8c to
0ea01ef
Compare
vigyasharma
force-pushed
the
vs-ac-listener
branch
from
0ea01ef to
4070fb3
Compare
sidheart
approved these changes
Jul 30, 2020
vigyasharma
force-pushed
the
vs-ac-listener
branch
from
4070fb3 to
d207d65
Compare
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
============================================
+ Coverage 67.23% 67.32% +0.08%
- Complexity 2002 2020 +18
============================================
Files 291 295 +4
Lines 12924 12974 +50
Branches 1057 1062 +5
============================================
+ Hits 8690 8735 +45
- Misses 3860 3864 +4
- Partials 374 375 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 316
#316
Description of changes: Allows users to plugin different action listeners to publisher. Action suggestions are published to each listener.
Tests: WIP
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.