Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Commit

Permalink
Remove action execute method
Browse files Browse the repository at this point in the history
  • Loading branch information
vigyasharma committed Jul 20, 2020
1 parent 3d7b459 commit 2c1e740
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,6 @@ public interface Action {
/** Time to wait since last recommendation, before suggesting this action again */
int coolOffPeriodInSeconds();

/**
* Called when the action is invoked.
*
* <p>Specific implementation may include executing the action, or invoking downstream APIs
*/
void execute();

/** Returns a list of Elasticsearch nodes impacted by this action. */
List<NodeKey> impactedNodes();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,6 @@ public Map<NodeKey, ImpactVector> impact() {
return Collections.singletonMap(esNode, impactVector);
}

@Override
public void execute() {
// Making this a no-op for now
// TODO: Modify based on downstream agent API calls
assert true;
}

@Override
public String summary() {
if (!isActionable()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ public EmptyFlowUnit operate() {

Decision decision = collator.getFlowUnits().get(0);
for (Action action : decision.getActions()) {
// LOG.info("Executing action: [{}]", action.name());
// action.execute();
for (ActionListener listener: actionListeners) {
listener.actionPublished(action);
}
Expand Down

0 comments on commit 2c1e740

Please sign in to comment.