Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Github action to build library artifacts #170

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#169

Description of changes:
This PR changes how the ODFE library artifacts are compiled and shipped. Now, we use a CentOS 7 container to build the RPM and ZIP and an Ubuntu 16.04 container to build the DEB.

In order to test, I created a subset of the action in my own repository and confirmed the artifacts build for each container.

TODO: Test artifacts that are built from containers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Jul 17, 2020
@peterzhuamazon
Copy link
Contributor

peterzhuamazon commented Jul 18, 2020

I have tested this newly compiled lib on these distributions and they all run without crashing:


  • debian ami-066027b63b44ebc0a
  • centos ami-0083662ba17882949
  • ubuntu ami-0ac80df6eff0e70b5
  • fedora ami-09f17ac4a76fd9ffe

All the tests shows correct results:
{"took":48,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}admin@ip-172-31-23-101:~$

{"took":21,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}[centos@ip-172-31-23-152 ~]$

{"took":54,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}ubuntu@ip-172-31-19-172:~$

{"took":50,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}[fedora@ip-172-31-20-15 ~]$

LGTM,
Thanks.

@jmazanec15 jmazanec15 changed the title Library artifact actions [WIP] Library artifact actions Jul 18, 2020
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmazanec15 Approved!

@jmazanec15 jmazanec15 merged commit 62ea02a into opendistro-for-elasticsearch:master Jul 22, 2020
@jmazanec15 jmazanec15 changed the title Library artifact actions Add Github action to build library artifacts Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants