-
Notifications
You must be signed in to change notification settings - Fork 56
Add Github action to build library artifacts #170
Add Github action to build library artifacts #170
Conversation
…rch/k-NN into library-artifact-actions
I have tested this newly compiled lib on these distributions and they all run without crashing:
All the tests shows correct results: {"took":21,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}[centos@ip-172-31-23-152 ~]$ {"took":54,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}ubuntu@ip-172-31-19-172:~$ {"took":50,"timed_out":false,"_shards":{"total":3,"successful":3,"skipped":0,"failed":0},"hits":{"total":{"value":6,"relation":"eq"},"max_score":0.32037726,"hits":[{"_index":"myindex2","_type":"_doc","_id":"5","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }},{"_index":"myindex2","_type":"_doc","_id":"7","_score":0.32037726,"_source":{ "my_vector" : [1.5, 2.5], "price": 10 }}]}}[fedora@ip-172-31-20-15 ~]$ LGTM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmazanec15 Approved!
Issue #, if available:
#169
Description of changes:
This PR changes how the ODFE library artifacts are compiled and shipped. Now, we use a CentOS 7 container to build the RPM and ZIP and an Ubuntu 16.04 container to build the DEB.
In order to test, I created a subset of the action in my own repository and confirmed the artifacts build for each container.
TODO: Test artifacts that are built from containers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.