Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

change side bar position for anomly detection plugin #335

Merged
merged 2 commits into from
Nov 25, 2020
Merged

change side bar position for anomly detection plugin #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31ef19a
change side bar position for anomly detection plugin
zhyuanqi Nov 25, 2020
48207ad
change side bar position for anomly detection plugin
zhyuanqi Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
CoreStart,
Plugin,
PluginInitializerContext,
DEFAULT_APP_CATEGORIES,
} from '../../../src/core/public';
import {
AnomalyDetectionKibanaPluginSetup,
Expand All @@ -40,8 +39,13 @@ export class AnomalyDetectionKibanaPlugin
core.application.register({
id: 'opendistro-anomaly-detection-kibana',
title: 'Anomaly Detection',
category: DEFAULT_APP_CATEGORIES.kibana,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change, can you also remove the unused import DEFAULT_APP_CATEGORIES at line 22 after the only usage is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Thanks for reminding.

order: 8030,
category: {
id: 'odfe',
label: 'Open Distro for Elasticsearch',
euiIconType: 'logoKibana',
order: 2000,
},
order: 5000,
mount: async (params: AppMountParameters) => {
const { renderApp } = await import('./anomaly_detection_app');
const [coreStart, depsStart] = await core.getStartServices();
Expand Down